artifact-store-tools: an image a definition pins, under any name the store has had, is named by a definition (hq issue 323) #249

Merged
mesh-admin merged 1 commits from fix/323-named-by-a-definition-2 into main 2026-10-12 13:08:32 +00:00
Contributor

Replaces #248, whose history held a real host name.

Fixes issue 323 (an image a definition pins under an older name of the store reads as unrecorded). Builds the design decided on the issue on 2026-10-11: the store's tools read every definition, under every name the store has had, and say "named by a definition: ".

What was wrong

artifact_store_references judged a manifest only by the controller's records, which name only what the mesh made. Three images the anchor runs are pinned by digest under an older name of the same store, and they read as unrecorded. That is the same word used for manifests nothing uses, so a later let-go rule could take running images.

What changes (modules/artifact-store-tools)

  • New state named-by-a-definition. It applies to a manifest that no record names but a definition pins by digest. why names the module and, for an older name, which one. A manifest the records name keeps the records' state. A platform manifest takes this state from the index a definition names (ADR 0257), ranked just after kept. A copy a definition names is not offered to the mirrors verb. It is never removable.
  • Reading definitions (definitions.go): through the catalogue (mesh-catalog.catalog_modules, then catalog_module per module at its commit), 8 at a time within 20 s, alongside the store listing. Each definition is kept per commit. Every string of a manifest (image, build base, file content) is searched for <name><repository>@sha256:<hex> under three kinds of name:
    • artifact-store://
    • the store's address from the controller
    • the older names
  • The older names are the mesh's setting older-store-names (preference, default none, trusted: false). The mesh writes it to ${dir:state}/store-names, and the bundle reads that file. A catalogue names no installation: the controller's module check refuses a host name in a definition, and a bundle's env may not carry ${setting:…} (ADR 0192). The module therefore gains its state directory and that one file.
  • Failure is loud. If the catalogue cannot be asked, a definition cannot be read, or the older names cannot be read, the first said line says that what they pin reads as unrecorded. The new definitions block gives the count read, the names used, unread, not_asked and older_store_names_not_read. The records are still answered.
  • invokes adds the catalogue's two tools. README and tool description updated.

Unlike #248, there is no offline catalogue check of pins under older names, because it needed the real name in the repository. The module's own classification and its "names not read" line carry it.

How it was tested

  • go vet, go test -race ./... in the module. New tests:
    • TestAnImageADefinitionPinsUnderAnOlderNameOfTheStoreIsNamedByADefinition
    • TestPinsAreFoundInEveryStringAndOnlyUnderTheStoresNames
    • TestAPlatformTakesTheStateOfAnIndexADefinitionNames
    • TestReferencesReadTheDefinitionsUnderTheStoresOlderNames (each definition read once per commit)
    • TestADefinitionNotReadIsSaidFirstAndLeavesWhatItPinsUnrecorded
    • TestTheOlderNamesAreReadFromTheFileTheMeshWrites
    • TestOlderNamesNotReadAreSaidFirst
    • TestNoCatalogueIsSaidAndNothingIsAsked
  • Tests use only placeholder names (registry-api.example.org, older.example, store:5000).
  • With the classification turned off, the three classification tests fail, so they fail without the fix.
  • MESH_GATE=<controller built from mesh-controller main db9e9c5> MESH_CHECK_MODULES=artifact-store-tools sh merge-check.sh passes.
  • The commit was grepped for real domains. Only the author line's email matches.

After delivery (needed for the acceptance)

Set older-store-names of artifact-store-tools with mesh-controller.settings to the store's former host. Then artifact_store_references says named-by-a-definition, with the module, for the three running apps' images.

Limits I chose

  • "Every definition" is what the catalogue's catalog_modules lists. A manifest in this repository that the catalogue does not hold is not read.
  • 20 s bound, 8 at a time. A first call after a restart reads about 150 definitions; later calls read only what changed commit.
  • With the setting at its default none, no warning is said. The default means "the store had no other name".
  • No warning in a module check for a pin under an older name. The decision asked for one, so it is left undone here. If wanted, it belongs in the controller's module check, reading the same setting.

Reviewers' checklist

  • Without the fix, the new classification tests fail. Checks are green.
  • Only an unrecorded manifest becomes named-by-a-definition. Records decide the rest.
  • Anything not read is said first.
  • Manifest: the setting is trusted: false, the file is in the module's own state directory, invokes lists the catalogue's two tools, and the module check is clean.
  • No real host name in the diff.

By fix-323@g14. Not merged.

Replaces #248, whose history held a real host name. Fixes issue 323 (an image a definition pins under an older name of the store reads as unrecorded). Builds the design decided on the issue on 2026-10-11: the store's tools read every definition, under every name the store has had, and say "named by a definition: <module>". ## What was wrong `artifact_store_references` judged a manifest only by the controller's records, which name only what the mesh made. Three images the anchor runs are pinned by digest under an older name of the same store, and they read as **unrecorded**. That is the same word used for manifests nothing uses, so a later let-go rule could take running images. ## What changes (modules/artifact-store-tools) - **New state `named-by-a-definition`.** It applies to a manifest that no record names but a definition pins by digest. `why` names the module and, for an older name, which one. A manifest the records name keeps the records' state. A platform manifest takes this state from the index a definition names (ADR 0257), ranked just after `kept`. A copy a definition names is not offered to the mirrors verb. It is never removable. - **Reading definitions** (`definitions.go`): through the catalogue (`mesh-catalog.catalog_modules`, then `catalog_module` per module at its commit), 8 at a time within 20 s, alongside the store listing. Each definition is kept per commit. Every string of a manifest (image, build base, file content) is searched for `<name><repository>@sha256:<hex>` under three kinds of name: - `artifact-store://` - the store's address from the controller - the older names - **The older names are the mesh's setting `older-store-names`** (preference, default `none`, `trusted: false`). The mesh writes it to `${dir:state}/store-names`, and the bundle reads that file. A catalogue names no installation: the controller's module check refuses a host name in a definition, and a bundle's env may not carry `${setting:…}` (ADR 0192). The module therefore gains its state directory and that one file. - **Failure is loud.** If the catalogue cannot be asked, a definition cannot be read, or the older names cannot be read, the first `said` line says that what they pin reads as unrecorded. The new `definitions` block gives the count read, the names used, `unread`, `not_asked` and `older_store_names_not_read`. The records are still answered. - `invokes` adds the catalogue's two tools. README and tool description updated. Unlike #248, there is no offline catalogue check of pins under older names, because it needed the real name in the repository. The module's own classification and its "names not read" line carry it. ## How it was tested - `go vet`, `go test -race ./...` in the module. New tests: - `TestAnImageADefinitionPinsUnderAnOlderNameOfTheStoreIsNamedByADefinition` - `TestPinsAreFoundInEveryStringAndOnlyUnderTheStoresNames` - `TestAPlatformTakesTheStateOfAnIndexADefinitionNames` - `TestReferencesReadTheDefinitionsUnderTheStoresOlderNames` (each definition read once per commit) - `TestADefinitionNotReadIsSaidFirstAndLeavesWhatItPinsUnrecorded` - `TestTheOlderNamesAreReadFromTheFileTheMeshWrites` - `TestOlderNamesNotReadAreSaidFirst` - `TestNoCatalogueIsSaidAndNothingIsAsked` - Tests use only placeholder names (`registry-api.example.org`, `older.example`, `store:5000`). - With the classification turned off, the three classification tests fail, so they fail without the fix. - `MESH_GATE=<controller built from mesh-controller main db9e9c5> MESH_CHECK_MODULES=artifact-store-tools sh merge-check.sh` passes. - The commit was grepped for real domains. Only the author line's email matches. ## After delivery (needed for the acceptance) Set `older-store-names` of artifact-store-tools with `mesh-controller.settings` to the store's former host. Then `artifact_store_references` says named-by-a-definition, with the module, for the three running apps' images. ## Limits I chose - "Every definition" is what the catalogue's `catalog_modules` lists. A manifest in this repository that the catalogue does not hold is not read. - 20 s bound, 8 at a time. A first call after a restart reads about 150 definitions; later calls read only what changed commit. - With the setting at its default `none`, no warning is said. The default means "the store had no other name". - No warning in a module check for a pin under an older name. The decision asked for one, so it is left undone here. If wanted, it belongs in the controller's `module check`, reading the same setting. ## Reviewers' checklist - [ ] Without the fix, the new classification tests fail. Checks are green. - [ ] Only an unrecorded manifest becomes named-by-a-definition. Records decide the rest. - [ ] Anything not read is said first. - [ ] Manifest: the setting is `trusted: false`, the file is in the module's own state directory, `invokes` lists the catalogue's two tools, and the module check is clean. - [ ] No real host name in the diff. By fix-323@g14. Not merged.
mesh-admin added 1 commit 2026-10-12 12:47:33 +00:00
artifact-store-tools: say an image a definition pins is named by a definition, under any name the store has had (issue 323)
mesh/merge-gate pass: builds artifact-store-tools → novox; no bus step; every machine composes with the change as it did without (4 of 4 compose)
mesh/repo-check pass: its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)
mesh/delivery delivered
d745a4d31e
No record names an image the mesh did not make, so one a definition pins under an
older name of the store read as unrecorded, the same word as an image nothing
uses. The tool now reads every definition through the catalogue and says
named-by-a-definition with the module. The store's older names are the mesh's
setting older-store-names, since a catalogue names no installation.
Author
Contributor

Delivery novox/mesh-catalog@d745a4d31ea5 — delivered since 2026-10-12T13:13:46Z

Delivery plan — builds artifact-store-tools → novox; no bus step

  • tier 0: artifact-store-tools
  • novox: receives artifact-store-tools

Machines

  • build-agent on ace: passed — carried by plan-1791810289819474207
  • artifact-store-tools on novox: passed — healthy 1 times over 25s
  • artifact-store-tools on the rest running it: sent

Transitions

  • 2026-10-12 12:47 (new) → proposed (announced): novox/mesh-catalog#249's head announced
  • 2026-10-12 12:51 proposed → checked (checked): the verdict names this commit
  • 2026-10-12 12:51 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-12 13:12 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-12 13:12 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
  • 2026-10-12 13:13 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-catalog@d745a4d31ea5` — **delivered** since 2026-10-12T13:13:46Z **Delivery plan** — builds artifact-store-tools → novox; no bus step - tier 0: artifact-store-tools - novox: receives artifact-store-tools **Machines** - build-agent on ace: passed — carried by plan-1791810289819474207 - artifact-store-tools on novox: passed — healthy 1 times over 25s - artifact-store-tools on the rest running it: sent **Transitions** - 2026-10-12 12:47 (new) → proposed (announced): novox/mesh-catalog#249's head announced - 2026-10-12 12:51 proposed → checked (checked): the verdict names this commit - 2026-10-12 12:51 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-12 13:12 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-12 13:12 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit - 2026-10-12 13:13 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
Author
Contributor

Merge check at d745a4d3

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: artifact-store-tools)
  • mesh/repo-check: PASS — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)

Delivery plan — builds artifact-store-tools → novox; no bus step

  • tier 0: artifact-store-tools
  • novox: receives artifact-store-tools

Run by the build seat on novox as build-1791809259102018493 (builds --log build-1791809259102018493).

--- the gate: artifact-store-tools
artifact-store-tools: ok, 4 tool(s), invokes seat:mesh-controller.artifacts, seat:mesh-controller.collect, mesh-catalog.catalog_modules, mesh-catalog.catalog_module
long-running resources without health: 0
files asking for a setting without saying whether it is trusted: 0
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T12:39:28Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-12T12:39:28Z

modules the change moves:
  - artifact-store-tools (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes; the change adds 2 resource(s) and removes 0 (+directory:artifact-store-tools.state, +file:artifact-store-tools.store-names)
  - a machine (yvbpsm): composes

a merge would rebuild 1 module(s) in 1 tier(s): artifact-store-tools
--- its merge-check.sh (go toolchain)
ok  	git.novox.be/novox/mesh-catalog/checks/words	0.008s
words: 12 retired words and 70 daemons' lines, none in the 43329 strings of 691 files
ok  	git.novox.be/novox/mesh-catalog/checks/agenthome	0.013s
agent-home: no archive and no file written into under the agent's home
ok  	git.novox.be/novox/mesh-catalog/checks/paths	0.006s
paths: no module names another's state on its machine (3 known, listed to go)
long-running resources without health: 69, as kept
ok  	git.novox.be/novox/mesh-catalog/checks/deps	0.252s
testing modules/artifact-store-tools
ok  	artifactstoretools/cmd/artifact-store-tools	1.049s
--- its merge-check-typescript.sh (typescript toolchain)
Unable to find image 'novox.internal:5100/mesh-tools/build@sha256:80574e27f7087675b9bbc18ab5676bceb9133866edb5e828ae18c4e26cb0c334' locally
novox.internal:5100/mesh-tools/build@sha256:80574e27f7087675b9bbc18ab5676bceb9133866edb5e828ae18c4e26cb0c334: Pulling from mesh-tools/build
501c3e032d32: Already exists
d456d1aa143e: Already exists
60f37e2c93ec: Already exists
e53f92c42dd6: Already exists
b571db164614: Already exists
c2fe729cfd79: Already exists
04e3f1b2fc31: Pulling fs layer
72c39a60d0db: Pulling fs layer
1f30a1e4018e: Pulling fs layer
d7012fa0974d: Pulling fs layer
17bcdd03abb6: Pulling fs layer
2af06d10bdf6: Pulling fs layer
2e14acb4849f: Pulling fs layer
92a8ecaa68e5: Pulling fs layer
d7012fa0974d: Waiting
17bcdd03abb6: Waiting
2af06d10bdf6: Waiting
2e14acb4849f: Waiting
92a8ecaa68e5: Waiting
04e3f1b2fc31: Verifying Checksum
1f30a1e4018e: Verifying Checksum
1f30a1e4018e: Download complete
d7012fa0974d: Download complete
2af06d10bdf6: Download complete
2e14acb4849f: Verifying Checksum
2e14acb4849f: Download complete
17bcdd03abb6: Verifying Checksum
17bcdd03abb6: Download complete
72c39a60d0db: Verifying Checksum
72c39a60d0db: Download complete
92a8ecaa68e5: Verifying Checksum
92a8ecaa68e5: Download complete
04e3f1b2fc31: Pull complete
72c39a60d0db: Pull complete
1f30a1e4018e: Pull complete
d7012fa0974d: Pull complete
17bcdd03abb6: Pull complete
2af06d10bdf6: Pull complete
2e14acb4849f: Pull complete
92a8ecaa68e5: Pull complete
Digest: sha256:80574e27f7087675b9bbc18ab5676bceb9133866edb5e828ae18c4e26cb0c334
Status: Downloaded newer image for novox.internal:5100/mesh-tools/build@sha256:80574e27f7087675b9bbc18ab5676bceb9133866edb5e828ae18c4e26cb0c334
**Merge check** at `d745a4d3` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: artifact-store-tools) - `mesh/repo-check`: **PASS** — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript) **Delivery plan** — builds artifact-store-tools → novox; no bus step - tier 0: artifact-store-tools - novox: receives artifact-store-tools Run by the build seat on novox as `build-1791809259102018493` (`builds --log build-1791809259102018493`). ``` --- the gate: artifact-store-tools artifact-store-tools: ok, 4 tool(s), invokes seat:mesh-controller.artifacts, seat:mesh-controller.collect, mesh-catalog.catalog_modules, mesh-catalog.catalog_module long-running resources without health: 0 files asking for a setting without saying whether it is trusted: 0 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T12:39:28Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-12T12:39:28Z modules the change moves: - artifact-store-tools (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes; the change adds 2 resource(s) and removes 0 (+directory:artifact-store-tools.state, +file:artifact-store-tools.store-names) - a machine (yvbpsm): composes a merge would rebuild 1 module(s) in 1 tier(s): artifact-store-tools --- its merge-check.sh (go toolchain) ok git.novox.be/novox/mesh-catalog/checks/words 0.008s words: 12 retired words and 70 daemons' lines, none in the 43329 strings of 691 files ok git.novox.be/novox/mesh-catalog/checks/agenthome 0.013s agent-home: no archive and no file written into under the agent's home ok git.novox.be/novox/mesh-catalog/checks/paths 0.006s paths: no module names another's state on its machine (3 known, listed to go) long-running resources without health: 69, as kept ok git.novox.be/novox/mesh-catalog/checks/deps 0.252s testing modules/artifact-store-tools ok artifactstoretools/cmd/artifact-store-tools 1.049s --- its merge-check-typescript.sh (typescript toolchain) Unable to find image 'novox.internal:5100/mesh-tools/build@sha256:80574e27f7087675b9bbc18ab5676bceb9133866edb5e828ae18c4e26cb0c334' locally novox.internal:5100/mesh-tools/build@sha256:80574e27f7087675b9bbc18ab5676bceb9133866edb5e828ae18c4e26cb0c334: Pulling from mesh-tools/build 501c3e032d32: Already exists d456d1aa143e: Already exists 60f37e2c93ec: Already exists e53f92c42dd6: Already exists b571db164614: Already exists c2fe729cfd79: Already exists 04e3f1b2fc31: Pulling fs layer 72c39a60d0db: Pulling fs layer 1f30a1e4018e: Pulling fs layer d7012fa0974d: Pulling fs layer 17bcdd03abb6: Pulling fs layer 2af06d10bdf6: Pulling fs layer 2e14acb4849f: Pulling fs layer 92a8ecaa68e5: Pulling fs layer d7012fa0974d: Waiting 17bcdd03abb6: Waiting 2af06d10bdf6: Waiting 2e14acb4849f: Waiting 92a8ecaa68e5: Waiting 04e3f1b2fc31: Verifying Checksum 1f30a1e4018e: Verifying Checksum 1f30a1e4018e: Download complete d7012fa0974d: Download complete 2af06d10bdf6: Download complete 2e14acb4849f: Verifying Checksum 2e14acb4849f: Download complete 17bcdd03abb6: Verifying Checksum 17bcdd03abb6: Download complete 72c39a60d0db: Verifying Checksum 72c39a60d0db: Download complete 92a8ecaa68e5: Verifying Checksum 92a8ecaa68e5: Download complete 04e3f1b2fc31: Pull complete 72c39a60d0db: Pull complete 1f30a1e4018e: Pull complete d7012fa0974d: Pull complete 17bcdd03abb6: Pull complete 2af06d10bdf6: Pull complete 2e14acb4849f: Pull complete 92a8ecaa68e5: Pull complete Digest: sha256:80574e27f7087675b9bbc18ab5676bceb9133866edb5e828ae18c4e26cb0c334 Status: Downloaded newer image for novox.internal:5100/mesh-tools/build@sha256:80574e27f7087675b9bbc18ab5676bceb9133866edb5e828ae18c4e26cb0c334 ```
Author
Contributor

Verdict: approve at d745a4d

Independent re-review (fresh clone, replacing #248). One commit, touches only modules/artifact-store-tools; the offline checks/storenames check is gone entirely from the diff and from the working tree.

No real domain anywhere in the commit. git diff main...d745a4d and git show d745a4d both grepped for novox.be: the only match in the whole commit is the author line's email (jschoubben@novox.be), which is normal git metadata, not repository content. registry-api.novox.be (the blocking string from #248) does not appear anywhere in the diff or the working tree. The only domain-shaped string the diff introduces is the placeholder registry-api.example.org, used consistently in definitions_test.go. docker.io appears only in a pre-existing test fixture (unchanged from main), as a generic upstream-registry example, not an installation name.

Classification behaviour is unchanged from #248. classify.go, tools.go, definitions.go and module.json are byte-identical to #248's versions (diffed directly against c0a2488). definitions_test.go differs only cosmetically — the fixture repository was renamed from novox/www/novox/tool to team/www/team/tool, presumably to scrub "novox" from test content too; no behavioural change. So everything I verified on #248 still holds here: a manifest the records name keeps the records' state (reclassification only fires when already unrecorded); the collect/sweep path passes defs=nil so removal is unaffected; UnrecordedMirrors only flags still-unrecorded entries, so a definition-pinned manifest is never offered to the mirrors verb; catalogue/older-names/per-module read failures are all said first and never silently promote a manifest out of unrecorded.

Tests. go vet ./... and go test -race -count=1 ./... both pass clean in modules/artifact-store-tools. Confirmed fail-without-fix by hand: commenting out the defs-based reclassification block in classify.go (lines 106–111, identical location to #248) makes TestAnImageADefinitionPinsUnderAnOlderNameOfTheStoreIsNamedByADefinition, TestAPlatformTakesTheStateOfAnIndexADefinitionNames and TestReferencesReadTheDefinitionsUnderTheStoresOlderNames fail exactly as before; restored, all pass again.

Required checks. mesh/merge-gate: success, 4 of 4 compose. mesh/repo-check: success (merge-check.sh and merge-check-typescript.sh both passed). Combined status: success.

The one gap noted on #248 — no test exercises the 20s timeout cutoff itself (the mock has no way to simulate a slow responder) — still applies here, but it's not blocking; the PR's own limits section acknowledges the module-check warning was intentionally left for a future change. Good to merge.

Verdict: approve at d745a4d Independent re-review (fresh clone, replacing #248). One commit, touches only modules/artifact-store-tools; the offline checks/storenames check is gone entirely from the diff and from the working tree. **No real domain anywhere in the commit.** `git diff main...d745a4d` and `git show d745a4d` both grepped for `novox.be`: the only match in the whole commit is the author line's email (`jschoubben@novox.be`), which is normal git metadata, not repository content. `registry-api.novox.be` (the blocking string from #248) does not appear anywhere in the diff or the working tree. The only domain-shaped string the diff introduces is the placeholder `registry-api.example.org`, used consistently in `definitions_test.go`. `docker.io` appears only in a pre-existing test fixture (unchanged from main), as a generic upstream-registry example, not an installation name. **Classification behaviour is unchanged from #248.** `classify.go`, `tools.go`, `definitions.go` and `module.json` are byte-identical to #248's versions (diffed directly against c0a2488). `definitions_test.go` differs only cosmetically — the fixture repository was renamed from `novox/www`/`novox/tool` to `team/www`/`team/tool`, presumably to scrub "novox" from test content too; no behavioural change. So everything I verified on #248 still holds here: a manifest the records name keeps the records' state (reclassification only fires when already `unrecorded`); the collect/sweep path passes `defs=nil` so removal is unaffected; `UnrecordedMirrors` only flags still-`unrecorded` entries, so a definition-pinned manifest is never offered to the mirrors verb; catalogue/older-names/per-module read failures are all said first and never silently promote a manifest out of `unrecorded`. **Tests.** `go vet ./...` and `go test -race -count=1 ./...` both pass clean in modules/artifact-store-tools. Confirmed fail-without-fix by hand: commenting out the `defs`-based reclassification block in `classify.go` (lines 106–111, identical location to #248) makes `TestAnImageADefinitionPinsUnderAnOlderNameOfTheStoreIsNamedByADefinition`, `TestAPlatformTakesTheStateOfAnIndexADefinitionNames` and `TestReferencesReadTheDefinitionsUnderTheStoresOlderNames` fail exactly as before; restored, all pass again. **Required checks.** mesh/merge-gate: success, 4 of 4 compose. mesh/repo-check: success (merge-check.sh and merge-check-typescript.sh both passed). Combined status: success. The one gap noted on #248 — no test exercises the 20s timeout cutoff itself (the mock has no way to simulate a slow responder) — still applies here, but it's not blocking; the PR's own limits section acknowledges the module-check warning was intentionally left for a future change. Good to merge.
mesh-admin merged commit 6190b40175 into main 2026-10-12 13:08:32 +00:00
mesh-admin deleted branch fix/323-named-by-a-definition-2 2026-10-12 13:08:32 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-catalog#249