mesh-delivery: a closed pull request's check builds go, and a walk says what each build did (ADR 0350, issue 649) #282

Merged

mesh-admin merged 1 commits from feat/350-one-build-per-change into main 2026-10-13 21:30:30 +00:00

Conversation 2 Commits 1 Files Changed 7

+98 -2

mesh-admin commented 2026-10-13 21:05:12 +00:00

Contributor

Copy Link

Copy Source

The catalogue's part of novox/hq ADR 0350 (one build per change), for issue 649.

after: novox/mesh-controller

What it does

• §5: closed unmerged. When the forge says a pull request closed unmerged, the delivery owner settles its deliveries as before. It then asks the controller's new forget-checks verb to let go of what that pull request's checks built for its merge. The call is made outside the lock. A refusal is said as a refusal, never fatal; the build seat's holders let go of anything a week old on their own. module.json invokes seat:mesh-controller.forget-checks.
• §4: per module, beside the walk. WalkModule.made is read from the controller's walk record ("reused from the check of owner/repo#n at head H (merged into trunk T): …" or "built: "). The delivery keeps it as walk.built per module, so show says it beside the walk's build.

Tests: TestAPullRequestClosedUnmergedLetsGoOfItsCheckBuilds and TestAWalksRecordSaysWhetherEachModuleWasReusedOrBuilt fail on main, where ForgetChecks and Made do not exist. The manifest test names the new invoke. go vet and go test -race pass for modules/mesh-delivery.

Order: after novox/mesh-controller#311. Merging this first does no harm. The invoke only grants a subject, and nothing serves that subject until the controller rolls out. Until then, a close is refused, the refusal is said, and the week's sweep lets go of the builds.

Issue 649. novox/hq ADR 0350.

The catalogue's part of novox/hq ADR 0350 (one build per change), for issue 649. after: novox/mesh-controller **What it does** - **§5: closed unmerged.** When the forge says a pull request closed unmerged, the delivery owner settles its deliveries as before. It then asks the controller's new `forget-checks` verb to let go of what that pull request's checks built for its merge. The call is made outside the lock. A refusal is said as a refusal, never fatal; the build seat's holders let go of anything a week old on their own. `module.json` invokes `seat:mesh-controller.forget-checks`. - **§4: per module, beside the walk.** `WalkModule.made` is read from the controller's walk record ("reused from the check of owner/repo#n at head H (merged into trunk T): …" or "built: <why>"). The delivery keeps it as `walk.built` per module, so `show` says it beside the walk's build. **Tests:** `TestAPullRequestClosedUnmergedLetsGoOfItsCheckBuilds` and `TestAWalksRecordSaysWhetherEachModuleWasReusedOrBuilt` fail on main, where `ForgetChecks` and `Made` do not exist. The manifest test names the new invoke. `go vet` and `go test -race` pass for modules/mesh-delivery. **Order:** after novox/mesh-controller#311. Merging this first does no harm. The invoke only grants a subject, and nothing serves that subject until the controller rolls out. Until then, a close is refused, the refusal is said, and the week's sweep lets go of the builds. Issue 649. novox/hq ADR 0350.

mesh-admin added 1 commit 2026-10-13 21:05:12 +00:00

Let a closed pull request's check builds go, and show what each walk build did ... 66d22dd53e

A check's builds for its merge have no taker once the pull request closes
unmerged, and the delivery should say whether a module was reused from the
check or built, and why (novox/hq ADR 0350 §4, §5).

mesh-admin commented 2026-10-13 21:05:37 +00:00

Author

Contributor

Copy Link

Copy Source

Delivery novox/mesh-catalog@66d22dd53eff — delivered since 2026-10-13T21:38:45Z

Delivery plan — builds mesh-delivery → novox; no bus step

• tier 0: mesh-delivery
• novox: receives mesh-delivery

Group feat/350-one-build-per-change, in order: novox/mesh-controller@5c606fd1d4 → novox/mesh-catalog@66d22dd53e

• novox/mesh-controller@5c606fd1d4 before novox/mesh-catalog@66d22dd53e: declared
• composed together: pass — every machine composes with the change as it did without (4 of 4 compose)

Machines

• mesh-controller on novox: passed — healthy 1 times over 1m44s, by the controller's rule: one reading once it is ready, after the node-engine's witness window (novox/hq ADR 0351)
• mesh-controller on the rest running it: sent
• build-agent on ace: passed — healthy 1 times over 33s, by a leaf module's rule: one reading (novox/hq ADR 0304)
• build-agent on the rest running it: sent
• mesh-delivery on novox: passed — healthy 1 times over 24s, by mesh-delivery's rule: one reading (novox/hq ADR 0351)
• mesh-delivery on the rest running it: sent

Transitions

• 2026-10-13 21:05 (new) → proposed (announced): novox/mesh-catalog#282's head announced
• 2026-10-13 21:08 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
• 2026-10-13 21:08 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
• 2026-10-13 21:32 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
• 2026-10-13 21:32 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
• 2026-10-13 21:38 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-catalog@66d22dd53eff` — **delivered** since 2026-10-13T21:38:45Z **Delivery plan** — builds mesh-delivery → novox; no bus step - tier 0: mesh-delivery - novox: receives mesh-delivery **Group** `feat/350-one-build-per-change`, in order: novox/mesh-controller@5c606fd1d48b → novox/mesh-catalog@66d22dd53eff - novox/mesh-controller@5c606fd1d48b before novox/mesh-catalog@66d22dd53eff: declared - composed together: pass — every machine composes with the change as it did without (4 of 4 compose) **Machines** - mesh-controller on novox: passed — healthy 1 times over 1m44s, by the controller's rule: one reading once it is ready, after the node-engine's witness window (novox/hq ADR 0351) - mesh-controller on the rest running it: sent - build-agent on ace: passed — healthy 1 times over 33s, by a leaf module's rule: one reading (novox/hq ADR 0304) - build-agent on the rest running it: sent - mesh-delivery on novox: passed — healthy 1 times over 24s, by mesh-delivery's rule: one reading (novox/hq ADR 0351) - mesh-delivery on the rest running it: sent **Transitions** - 2026-10-13 21:05 (new) → proposed (announced): novox/mesh-catalog#282's head announced - 2026-10-13 21:08 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-13 21:08 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-13 21:32 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-13 21:32 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit - 2026-10-13 21:38 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.

mesh-admin commented 2026-10-13 21:08:47 +00:00

Author

Contributor

Copy Link

Copy Source

Merge check at 66d22dd5
Judged: head 66d22dd53eff merged into trunk 7ed119995f69; read beside it: mesh-controller bff5b7f0e4f8, mesh-controller-main bff5b7f0e4f8, mesh-host 0e92ef3d1b21, mesh-tools 954e1a53eef9

• mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: mesh-delivery)
• mesh/repo-check: PASS — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)

Delivery plan — builds mesh-delivery → novox; no bus step

• tier 0: mesh-delivery
• novox: receives mesh-delivery
• read by no module's build: modules/mesh-delivery/cmd/mesh-delivery/adr350_test.go, modules/mesh-delivery/cmd/mesh-delivery/fakes_test.go, modules/mesh-delivery/cmd/mesh-delivery/manifest_test.go

Run by the build seat on novox as build-1791925532351512442 (builds --log build-1791925532351512442).

--- the gate: mesh-delivery
mesh-delivery: ok, 1 tool(s), invokes seat:mesh-controller.delivery-plan, seat:mesh-controller.delivery-order, seat:mesh-controller.delivery-check, seat:mesh-controller.deliver, seat:mesh-controller.delivery-stop, seat:mesh-controller.delivery-walks, seat:mesh-controller.forget-checks, gitea.gitea_note_append, gitea.gitea_delivery_view, gitea.gitea_commit_status, gitea.gitea_commit_statuses, gitea.gitea_contains, gitea.gitea_open_pulls, keeps state deliveries, groups
long-running resources without health: 0
files asking for a setting without saying whether it is trusted: 0
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-13T20:17:05Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-13T20:17:05Z

modules the change moves:
  - mesh-delivery (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 1 module(s) in 1 tier(s): mesh-delivery

notes:
  - modules/mesh-delivery/cmd/mesh-delivery/adr350_test.go, modules/mesh-delivery/cmd/mesh-delivery/fakes_test.go and modules/mesh-delivery/cmd/mesh-delivery/manifest_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	git.novox.be/novox/mesh-catalog/checks/words	0.003s
words: 12 retired words and 70 daemons' lines, none in the 46786 strings of 718 files
ok  	git.novox.be/novox/mesh-catalog/checks/agenthome	0.014s
agent-home: no archive and no file written into under the agent's home
ok  	git.novox.be/novox/mesh-catalog/checks/secrets	0.013s
secrets: no setting can replace a vault secret in a mergeable file (1 known, nested)
ok  	git.novox.be/novox/mesh-catalog/checks/paths	0.007s
paths: no module names another's state on its machine (3 known, listed to go)
long-running resources without health: 66, as kept
ok  	git.novox.be/novox/mesh-catalog/checks/deps	0.366s
testing modules/mesh-delivery
ok  	mesh-delivery/cmd/mesh-delivery	3.324s
--- its merge-check-typescript.sh (typescript toolchain)

**Merge check** at `66d22dd5` Judged: head `66d22dd53eff` merged into trunk `7ed119995f69`; read beside it: mesh-controller `bff5b7f0e4f8`, mesh-controller-main `bff5b7f0e4f8`, mesh-host `0e92ef3d1b21`, mesh-tools `954e1a53eef9` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: mesh-delivery) - `mesh/repo-check`: **PASS** — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript) **Delivery plan** — builds mesh-delivery → novox; no bus step - tier 0: mesh-delivery - novox: receives mesh-delivery - read by no module's build: modules/mesh-delivery/cmd/mesh-delivery/adr350_test.go, modules/mesh-delivery/cmd/mesh-delivery/fakes_test.go, modules/mesh-delivery/cmd/mesh-delivery/manifest_test.go Run by the build seat on novox as `build-1791925532351512442` (`builds --log build-1791925532351512442`). ``` --- the gate: mesh-delivery mesh-delivery: ok, 1 tool(s), invokes seat:mesh-controller.delivery-plan, seat:mesh-controller.delivery-order, seat:mesh-controller.delivery-check, seat:mesh-controller.deliver, seat:mesh-controller.delivery-stop, seat:mesh-controller.delivery-walks, seat:mesh-controller.forget-checks, gitea.gitea_note_append, gitea.gitea_delivery_view, gitea.gitea_commit_status, gitea.gitea_commit_statuses, gitea.gitea_contains, gitea.gitea_open_pulls, keeps state deliveries, groups long-running resources without health: 0 files asking for a setting without saying whether it is trusted: 0 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-13T20:17:05Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-13T20:17:05Z modules the change moves: - mesh-delivery (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 1 module(s) in 1 tier(s): mesh-delivery notes: - modules/mesh-delivery/cmd/mesh-delivery/adr350_test.go, modules/mesh-delivery/cmd/mesh-delivery/fakes_test.go and modules/mesh-delivery/cmd/mesh-delivery/manifest_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok git.novox.be/novox/mesh-catalog/checks/words 0.003s words: 12 retired words and 70 daemons' lines, none in the 46786 strings of 718 files ok git.novox.be/novox/mesh-catalog/checks/agenthome 0.014s agent-home: no archive and no file written into under the agent's home ok git.novox.be/novox/mesh-catalog/checks/secrets 0.013s secrets: no setting can replace a vault secret in a mergeable file (1 known, nested) ok git.novox.be/novox/mesh-catalog/checks/paths 0.007s paths: no module names another's state on its machine (3 known, listed to go) long-running resources without health: 66, as kept ok git.novox.be/novox/mesh-catalog/checks/deps 0.366s testing modules/mesh-delivery ok mesh-delivery/cmd/mesh-delivery 3.324s --- its merge-check-typescript.sh (typescript toolchain) ```

mesh-admin referenced this pull request from novox/hq 2026-10-13 21:18:26 +00:00

To-be 47: a change is built once, at its check (ADR 0350, issue 649) #348

mesh-admin merged commit 23a2e1e204 into main 2026-10-13 21:30:30 +00:00

mesh-admin deleted branch feat/350-one-build-per-change 2026-10-13 21:30:31 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

jschoubben miel.truyen

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-catalog#282