Say once after a restart that nothing waits, so an old retirement condition clears (issue 937) #335

Merged
mesh-tools merged 1 commits from fix/937-settle-after-restart into main 2026-10-16 16:45:30 +00:00
Member

Issue 937, second part. After #334 was delivered (18:35), postgres on ace and novox waits on nothing (provisioner_retirement: waiting null, nothing retired), but the conditions provider.postgres.{ace,novox}.retire stay raised and keep asking the operator to approve.

Cause. The controller clears retire-waiting and retire-rejected only on a provider's settled word (mesh-controller cmd/mesh-controller/retirement.go Retired); a provider says settled only for a set its own memory held, and a restarted provider never knew the old set.

Fix. The first pass of a process that finds every consumer held asked for says settled once, with no set (link.ReadRetirement accepts an empty list). Identical in keycloak's retirement.go and retirement_test.go (harness_same_test); both standing_test.go captures skip that one word, as they skip first-success.

Tests. Two new unit tests in retirement_test.go; TestARestartedProviderSaysOnceThatNothingWaits fails on main's retirement.go. postgres suite 0.13 s, keycloak 0.15 s.

Review. Same reviewer, round 2 of at most 3: approved at tree 7b498fb4 = this head's tree. No issues opened.

Issue 937, second part. After #334 was delivered (18:35), postgres on ace and novox waits on nothing (provisioner_retirement: waiting null, nothing retired), but the conditions provider.postgres.{ace,novox}.retire stay raised and keep asking the operator to approve. **Cause.** The controller clears retire-waiting and retire-rejected only on a provider's settled word (mesh-controller cmd/mesh-controller/retirement.go Retired); a provider says settled only for a set its own memory held, and a restarted provider never knew the old set. **Fix.** The first pass of a process that finds every consumer held asked for says settled once, with no set (link.ReadRetirement accepts an empty list). Identical in keycloak's retirement.go and retirement_test.go (harness_same_test); both standing_test.go captures skip that one word, as they skip first-success. **Tests.** Two new unit tests in retirement_test.go; TestARestartedProviderSaysOnceThatNothingWaits fails on main's retirement.go. postgres suite 0.13 s, keycloak 0.15 s. **Review.** Same reviewer, round 2 of at most 3: approved at tree 7b498fb4 = this head's tree. No issues opened.
mesh-tools added 1 commit 2026-10-16 16:42:52 +00:00
Say once after a restart that nothing waits, so an old retirement condition clears (issue 937)
mesh/merge-gate head d7a880a60878 merged into trunk 3ee754eb3b0c — pass: builds keycloak, postgres, sent nowhere; no bus step; 3 wait(s) for a person; ever…
mesh/repo-check head d7a880a60878 merged into trunk 3ee754eb3b0c — pass: its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-…
mesh/delivery delivered
d7a880a608
The controller clears a provider's retire-waiting condition only on its
settled word, and a provider says settled only for a set its own memory
held. A provider restarted after the set stopped waiting (here: the
delivery of the grant-file fix) never says it, so the condition kept
asking the operator to approve retiring what nobody waits on. The first
pass of a process that finds every consumer asked now says settled once,
with no set; the controller clears both conditions on it.
mesh-tools added the mesh/ready label 2026-10-16 16:42:57 +00:00
Author
Member

ready at d7a880a608

Reviewed by review-937@novox: approved round 2 of at most 3 at tree 7b498fb4, which this head carries: a restarted provider says once that nothing waits; no change asked. Marked through mesh-delivery.mark-ready (novox/hq issue 913).

ready at d7a880a608789cd0f8c6022f3bdddd9af751c814 Reviewed by review-937@novox: approved round 2 of at most 3 at tree 7b498fb4, which this head carries: a restarted provider says once that nothing waits; no change asked. Marked through mesh-delivery.mark-ready (novox/hq issue 913).
Author
Member

Delivery novox/mesh-catalog@d7a880a60878 — delivered since 2026-10-16T16:48:56Z

Delivery plan — builds keycloak, postgres, sent nowhere; no bus step; 3 wait(s) for a person

  • tier 0: keycloak, postgres
  • ace: waits for a person: postgres
  • novox: waits for a person: keycloak, postgres
  • keycloak waits for a person: its policy records (module) — unless on a machine its move recreates none of its containers and moves none of its data, which the walk judges and then sends
  • keycloak provides oidc-client: its consumers are sent again after it
  • keycloak keeps data (ADR 0233): what it holds is backed up before it moves
  • postgres waits for a person: its policy records (module) — unless on a machine its move recreates none of its containers and moves none of its data, which the walk judges and then sends
  • postgres provides postgres-database: its consumers are sent again after it
  • postgres keeps data (ADR 0233): what it holds is backed up before it moves

Machines

  • keycloak on every machine running it: sent
  • postgres on every machine running it: sent

Transitions

  • 2026-10-16 16:42 (new) → proposed (announced): novox/mesh-catalog#335's head announced
  • 2026-10-16 16:45 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
  • 2026-10-16 16:45 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-16 16:45 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-16 16:45 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
  • 2026-10-16 16:48 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-catalog@d7a880a60878` — **delivered** since 2026-10-16T16:48:56Z **Delivery plan** — builds keycloak, postgres, sent nowhere; no bus step; 3 wait(s) for a person - tier 0: keycloak, postgres - ace: waits for a person: postgres - novox: waits for a person: keycloak, postgres - keycloak waits for a person: its policy records (module) — unless on a machine its move recreates none of its containers and moves none of its data, which the walk judges and then sends - keycloak provides oidc-client: its consumers are sent again after it - keycloak keeps data (ADR 0233): what it holds is backed up before it moves - postgres waits for a person: its policy records (module) — unless on a machine its move recreates none of its containers and moves none of its data, which the walk judges and then sends - postgres provides postgres-database: its consumers are sent again after it - postgres keeps data (ADR 0233): what it holds is backed up before it moves **Machines** - keycloak on every machine running it: sent - postgres on every machine running it: sent **Transitions** - 2026-10-16 16:42 (new) → proposed (announced): novox/mesh-catalog#335's head announced - 2026-10-16 16:45 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-16 16:45 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-16 16:45 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-16 16:45 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit - 2026-10-16 16:48 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
Author
Member

Merge check at d7a880a6
Judged: head d7a880a60878 merged into trunk 3ee754eb3b0c; read beside it: mesh-controller c7cb9f0a2cd3, mesh-controller-main c7cb9f0a2cd3, mesh-host cd13f7726ef0, mesh-tools 7412c5b6c9c5

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: keycloak, postgres)
  • mesh/repo-check: PASS — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)

Delivery plan — builds keycloak, postgres, sent nowhere; no bus step; 3 wait(s) for a person

  • tier 0: keycloak, postgres
  • ace: waits for a person: postgres
  • novox: waits for a person: keycloak, postgres
  • keycloak waits for a person: its policy records (module) — unless on a machine its move recreates none of its containers and moves none of its data, which the walk judges and then sends
  • keycloak provides oidc-client: its consumers are sent again after it
  • keycloak keeps data (ADR 0233): what it holds is backed up before it moves
  • postgres waits for a person: its policy records (module) — unless on a machine its move recreates none of its containers and moves none of its data, which the walk judges and then sends
  • postgres provides postgres-database: its consumers are sent again after it
  • postgres keeps data (ADR 0233): what it holds is backed up before it moves
  • read by no module's build: modules/keycloak/cmd/keycloak-provider/retirement_test.go, modules/keycloak/cmd/keycloak-provider/standing_test.go, modules/postgres/cmd/postgres-provider/retirement_test.go, modules/postgres/cmd/postgres-provider/standing_test.go

Run by the build seat on ace as build-1792168974670630712 (builds --log build-1792168974670630712).

--- the gate: keycloak, postgres
keycloak: ok, keeps state bound, reads mesh-controller.assignments; WARNING: runtime-config ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: server stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
postgres: ok, keeps state bound, reads mesh-controller.assignments, keeps store (valuable), dumps (rebuildable), ready: server by tcp on database every 30s
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
2 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-16T16:34:22Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-16T16:34:22Z

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-config, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-provisioner, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 2 module(s) in 1 tier(s): keycloak, postgres

notes:
  - modules/keycloak/cmd/keycloak-provider/retirement_test.go, modules/keycloak/cmd/keycloak-provider/standing_test.go, modules/postgres/cmd/postgres-provider/retirement_test.go and modules/postgres/cmd/postgres-provider/standing_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	git.novox.be/novox/mesh-catalog/checks/words	0.003s
words: 12 retired words and 70 daemons' lines, none in the 53628 strings of 801 files
ok  	git.novox.be/novox/mesh-catalog/checks/agenthome	0.014s
agent-home: no archive and no file written into under the agent's home
ok  	git.novox.be/novox/mesh-catalog/checks/mailstore	0.009s
mail-store: claimed only by mesh-mail
ok  	git.novox.be/novox/mesh-catalog/checks/secrets	0.014s
secrets: no setting can replace a vault secret in a mergeable file (1 known, nested)
ok  	git.novox.be/novox/mesh-catalog/checks/predefined	0.247s
predefined.json: 2 key(s), none removed that a module names
ok  	git.novox.be/novox/mesh-catalog/checks/config	0.014s
config: no moved module says settings, takes-settings or ${setting:<key>}, or takes a whole layer (0 not yet moved)
ok  	git.novox.be/novox/mesh-catalog/checks/templates	0.011s
templates: no module keeps a file's text inline but the 0 listed
ok  	git.novox.be/novox/mesh-catalog/checks/paths	0.006s
paths: no module names another's state on its machine (3 known, listed to go)
long-running resources without health: 61, as kept
ok  	git.novox.be/novox/mesh-catalog/checks/deps	0.223s
testing modules/keycloak
ok  	keycloak/cmd/keycloak-provider	1.397s
testing modules/postgres
ok  	postgres/cmd/postgres-provider	1.370s
--- its merge-check-typescript.sh (typescript toolchain)
**Merge check** at `d7a880a6` Judged: head `d7a880a60878` merged into trunk `3ee754eb3b0c`; read beside it: mesh-controller `c7cb9f0a2cd3`, mesh-controller-main `c7cb9f0a2cd3`, mesh-host `cd13f7726ef0`, mesh-tools `7412c5b6c9c5` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: keycloak, postgres) - `mesh/repo-check`: **PASS** — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript) **Delivery plan** — builds keycloak, postgres, sent nowhere; no bus step; 3 wait(s) for a person - tier 0: keycloak, postgres - ace: waits for a person: postgres - novox: waits for a person: keycloak, postgres - keycloak waits for a person: its policy records (module) — unless on a machine its move recreates none of its containers and moves none of its data, which the walk judges and then sends - keycloak provides oidc-client: its consumers are sent again after it - keycloak keeps data (ADR 0233): what it holds is backed up before it moves - postgres waits for a person: its policy records (module) — unless on a machine its move recreates none of its containers and moves none of its data, which the walk judges and then sends - postgres provides postgres-database: its consumers are sent again after it - postgres keeps data (ADR 0233): what it holds is backed up before it moves - read by no module's build: modules/keycloak/cmd/keycloak-provider/retirement_test.go, modules/keycloak/cmd/keycloak-provider/standing_test.go, modules/postgres/cmd/postgres-provider/retirement_test.go, modules/postgres/cmd/postgres-provider/standing_test.go Run by the build seat on ace as `build-1792168974670630712` (`builds --log build-1792168974670630712`). ``` --- the gate: keycloak, postgres keycloak: ok, keeps state bound, reads mesh-controller.assignments; WARNING: runtime-config ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: server stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) postgres: ok, keeps state bound, reads mesh-controller.assignments, keeps store (valuable), dumps (rebuildable), ready: server by tcp on database every 30s long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 2 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-16T16:34:22Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-16T16:34:22Z machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-config, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-provisioner, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 2 module(s) in 1 tier(s): keycloak, postgres notes: - modules/keycloak/cmd/keycloak-provider/retirement_test.go, modules/keycloak/cmd/keycloak-provider/standing_test.go, modules/postgres/cmd/postgres-provider/retirement_test.go and modules/postgres/cmd/postgres-provider/standing_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok git.novox.be/novox/mesh-catalog/checks/words 0.003s words: 12 retired words and 70 daemons' lines, none in the 53628 strings of 801 files ok git.novox.be/novox/mesh-catalog/checks/agenthome 0.014s agent-home: no archive and no file written into under the agent's home ok git.novox.be/novox/mesh-catalog/checks/mailstore 0.009s mail-store: claimed only by mesh-mail ok git.novox.be/novox/mesh-catalog/checks/secrets 0.014s secrets: no setting can replace a vault secret in a mergeable file (1 known, nested) ok git.novox.be/novox/mesh-catalog/checks/predefined 0.247s predefined.json: 2 key(s), none removed that a module names ok git.novox.be/novox/mesh-catalog/checks/config 0.014s config: no moved module says settings, takes-settings or ${setting:<key>}, or takes a whole layer (0 not yet moved) ok git.novox.be/novox/mesh-catalog/checks/templates 0.011s templates: no module keeps a file's text inline but the 0 listed ok git.novox.be/novox/mesh-catalog/checks/paths 0.006s paths: no module names another's state on its machine (3 known, listed to go) long-running resources without health: 61, as kept ok git.novox.be/novox/mesh-catalog/checks/deps 0.223s testing modules/keycloak ok keycloak/cmd/keycloak-provider 1.397s testing modules/postgres ok postgres/cmd/postgres-provider 1.370s --- its merge-check-typescript.sh (typescript toolchain) ```
mesh-tools merged commit 832a0afd18 into main 2026-10-16 16:45:30 +00:00
mesh-tools deleted branch fix/937-settle-after-restart 2026-10-16 16:45:31 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-catalog#335