xterm: every resource a config value, today's values as defaults (issue 1656) #416

Merged
mesh-tools merged 3 commits from fix/1656-xterm-config into main 2026-10-21 18:36:29 +00:00
Member

Delivery group fix/1656-xterm-config with mesh-controller#420.

Issue 1656: every value xterm's resources set is a config value (ADR 0348) with today's value as its default; files/xresources-normal holds ${config:} placeholders only; size falls back to the predefined font-size like dunst's; xterm_font and xterm_colours report the rendered value, and tools.go keeps no copy of the defaults. The clipboard keys are copy-binding and paste-binding (issue note, 1656/AC1 amended). Rendered with defaults, the template equals today's resources byte for byte, so no machine's resources change on delivery.

Tests: 1656/AC1-AC4 (unit, modules/xterm/cmd/xterm-tools). AC5 (size 10 on shanks through mesh-config) is proved after delivery. Needs mesh-sdk at 07a65927 (issue 1658), which the controller member pins.

Since the earlier review at f178aab6 this head holds only merges of main (nothing under modules/xterm changed).

Reviewed-by: reviewer-xterm@shanks at b9dcf19c3f

Delivery group fix/1656-xterm-config with mesh-controller#420. Issue 1656: every value xterm's resources set is a config value (ADR 0348) with today's value as its default; files/xresources-normal holds ${config:<key>} placeholders only; size falls back to the predefined font-size like dunst's; xterm_font and xterm_colours report the rendered value, and tools.go keeps no copy of the defaults. The clipboard keys are copy-binding and paste-binding (issue note, 1656/AC1 amended). Rendered with defaults, the template equals today's resources byte for byte, so no machine's resources change on delivery. Tests: 1656/AC1-AC4 (unit, modules/xterm/cmd/xterm-tools). AC5 (size 10 on shanks through mesh-config) is proved after delivery. Needs mesh-sdk at 07a65927 (issue 1658), which the controller member pins. Since the earlier review at f178aab6 this head holds only merges of main (nothing under modules/xterm changed). Reviewed-by: reviewer-xterm@shanks at b9dcf19c3f910f604f188380d809b96f5e69780b
mesh-tools added 1 commit 2026-10-21 13:12:56 +00:00
Make every xterm resource a config value with today's value as default; tools read the rendered resources (issue 1656)
mesh/delivery-group group fix/1656-xterm-config rejected: a member's own check failed
mesh/merge-gate waits for its group's composed check
mesh/repo-check head f178aab641dc merged into trunk 3259765d46bc beside mesh-controller#420@69a67876 — fail: its merge-check.sh failed: files asking for a …
mesh/delivery superseded: a newer head of the same pull request
f178aab641
Author
Member

Delivery novox/mesh-catalog@b9dcf19c3f91 — failed since 2026-10-21T18:59:01Z

Delivery plan — builds xterm → g14, shanks; no bus step

  • tier 0: xterm
  • g14: receives xterm
  • shanks: receives xterm
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before xterm is judged on its first machine

Group fix/1656-xterm-config: novox/mesh-catalog@b9dcf19c3f, novox/mesh-controller@9d260412b3

  • composed together: pass — every machine composes with the change as it did without (4 of 4 compose)

Machines

  • mesh-controller on every machine running it: sent
  • route-proxy on every machine running it: sent

Transitions

  • 2026-10-21 17:43 (new) → proposed (announced): novox/mesh-catalog#416's head announced
  • 2026-10-21 17:52 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
  • 2026-10-21 17:52 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-21 18:19 ready → proposed (trunk moved): out of date: judged against trunk c3564c1acc, the trunk is now db5e6c5b48f4; judged again on a recheck or when it is merged
  • 2026-10-21 18:23 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
  • 2026-10-21 18:23 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-21 18:38 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-21 18:38 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
  • 2026-10-21 18:59 delivering → failed (failed): its walk failed, carrying its own commit: a gate on a first machine (what it carried put back), a build, a machine

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-catalog@b9dcf19c3f91` — **failed** since 2026-10-21T18:59:01Z **Delivery plan** — builds xterm → g14, shanks; no bus step - tier 0: xterm - g14: receives xterm - shanks: receives xterm - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before xterm is judged on its first machine **Group** `fix/1656-xterm-config`: novox/mesh-catalog@b9dcf19c3f91, novox/mesh-controller@9d260412b330 - composed together: pass — every machine composes with the change as it did without (4 of 4 compose) **Machines** - mesh-controller on every machine running it: sent - route-proxy on every machine running it: sent **Transitions** - 2026-10-21 17:43 (new) → proposed (announced): novox/mesh-catalog#416's head announced - 2026-10-21 17:52 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-21 17:52 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-21 18:19 ready → proposed (trunk moved): out of date: judged against trunk c3564c1accf3, the trunk is now db5e6c5b48f4; judged again on a recheck or when it is merged - 2026-10-21 18:23 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-21 18:23 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-21 18:38 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-21 18:38 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit - 2026-10-21 18:59 delivering → failed (failed): its walk failed, carrying its own commit: a gate on a first machine (what it carried put back), a build, a machine The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
Author
Member

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: its head c8e35097e861 is no longer the pull request's head, or the pull request closed. Nothing is merged on it. The operator is asked again once the checks pass at the new head.

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: its head c8e35097e861 is no longer the pull request's head, or the pull request closed. Nothing is merged on it. The operator is asked again once the checks pass at the new head.
Author
Member

mesh-delivery: not merged. This pull request's checks passed at f178aab641, and now its check failed: judged by its group's composed check (head f178aab641 merged into trunk 3259765d46). A new head, or a recheck that passes, asks the operator again.

mesh-delivery: **not merged.** This pull request's checks passed at f178aab641dca85abbaacf97797110a5931633a1, and now its check failed: judged by its group's composed check (head f178aab641dc merged into trunk 3259765d46bc). A new head, or a recheck that passes, asks the operator again.
jschoubben added 1 commit 2026-10-21 17:16:51 +00:00
Merge remote-tracking branch 'origin/main' into fix/1656-xterm-config
mesh/merge-gate out of date: judged against trunk 7a7a4034852a, the trunk is now c3564c1accf3; judged again on a recheck or when it is merged
mesh/repo-check out of date: judged against trunk 7a7a4034852a, the trunk is now c3564c1accf3; judged again on a recheck or when it is merged
mesh/delivery superseded: a newer head of the same pull request
e4cbffbaa9
Author
Member

Merge check at e4cbffba
Judged: head e4cbffbaa95b merged into trunk 7a7a4034852a
Siblings read beside it: novox/mesh-controller#420 69a67876c269 merged onto 5ba2ffe8e608 (main)

  • mesh/merge-gate: FAIL — the sibling novox/mesh-controller#420 (head 69a67876c269) does not merge cleanly into its base main 5ba2ffe8e608: in conflict go.mod, go.sum, testdata/beside/CAPTURED, vendor/modules.txt
  • mesh/repo-check: FAIL — the sibling novox/mesh-controller#420 (head 69a67876c269) does not merge cleanly into its base main 5ba2ffe8e608: in conflict go.mod, go.sum, testdata/beside/CAPTURED, vendor/modules.txt

Delivery plan — builds xterm → g14, shanks; no bus step

  • tier 0: xterm
  • g14: receives xterm
  • shanks: receives xterm
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before xterm is judged on its first machine
  • read by no module's build: modules/xterm/README.md, modules/xterm/cmd/xterm-tools/config_test.go, modules/xterm/cmd/xterm-tools/xterm_test.go

Run by the build seat on g14 as build-1792603022781370183 (builds --log build-1792603022781370183).

the sibling novox/mesh-controller#420 (head 69a67876c269) does not merge cleanly into its base main 5ba2ffe8e608: in conflict go.mod, go.sum, testdata/beside/CAPTURED, vendor/modules.txt

Out of date when it landed: out of date: judged against trunk 7a7a403485, the trunk is now c3564c1accf3; judged again on a recheck or when it is merged

**Merge check** at `e4cbffba` Judged: head `e4cbffbaa95b` merged into trunk `7a7a4034852a` Siblings read beside it: novox/mesh-controller#420 `69a67876c269` merged onto `5ba2ffe8e608` (main) - `mesh/merge-gate`: **FAIL** — the sibling novox/mesh-controller#420 (head 69a67876c269) does not merge cleanly into its base main 5ba2ffe8e608: in conflict go.mod, go.sum, testdata/beside/CAPTURED, vendor/modules.txt - `mesh/repo-check`: **FAIL** — the sibling novox/mesh-controller#420 (head 69a67876c269) does not merge cleanly into its base main 5ba2ffe8e608: in conflict go.mod, go.sum, testdata/beside/CAPTURED, vendor/modules.txt **Delivery plan** — builds xterm → g14, shanks; no bus step - tier 0: xterm - g14: receives xterm - shanks: receives xterm - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before xterm is judged on its first machine - read by no module's build: modules/xterm/README.md, modules/xterm/cmd/xterm-tools/config_test.go, modules/xterm/cmd/xterm-tools/xterm_test.go Run by the build seat on g14 as `build-1792603022781370183` (`builds --log build-1792603022781370183`). ``` the sibling novox/mesh-controller#420 (head 69a67876c269) does not merge cleanly into its base main 5ba2ffe8e608: in conflict go.mod, go.sum, testdata/beside/CAPTURED, vendor/modules.txt ``` **Out of date when it landed**: out of date: judged against trunk 7a7a4034852a, the trunk is now c3564c1accf3; judged again on a recheck or when it is merged
jschoubben added 1 commit 2026-10-21 17:43:37 +00:00
Merge remote-tracking branch 'origin/main' into fix/1656-xterm-config
mesh/repo-check head b9dcf19c3f91 merged into trunk db5e6c5b48f4 beside mesh-controller#420@9d260412 — pass: its merge-check.sh passed, each part in its to…
mesh/merge-gate head b9dcf19c3f91 merged into trunk db5e6c5b48f4 — pass: group fix/1656-xterm-config composed: every machine composes with the change as it…
mesh/delivery failed: its walk failed, carrying its own commit: a gate on a first machine (what it carried put back), a build, a machine
mesh/delivery-group group fix/1656-xterm-config failed: a member failed
b9dcf19c3f
mesh-tools merged commit cdbdb47474 into main 2026-10-21 18:36:29 +00:00
mesh-tools deleted branch fix/1656-xterm-config 2026-10-21 18:36:30 +00:00
Sign in to join this conversation.
No Reviewers
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-catalog#416