gitea's watcher answers its handshake without waiting for the forge, so a slow forge at a tool-runner restart no longer kills its tools and events (issue 1726) #471

2026-10-24T11:09:13Z

mesh-tools commented

2026-10-24 11:09:13 +00:00

Issue 1726, note 26: when novox's tool runner was replaced at 12:37, gitea's watcher bundle waited at import for the forge's admin API (ensureSystemHook) past the 10 s handshake; the tool runner never starts a bundle again after a failed first handshake, so gitea_commit_status, gitea_merge_pull_request and gitea_events went unserved and no gitea.pull.* event reached the bus: no new pull request was announced, no status written.

modules/gitea/index.ts no longer awaits the webhook set-up at import (void listenForForge(client)); its failure stays loud (gitea_events unhealthy, logged); the polls keep their 30 s pace until the webhook listens, so no pull event is missed. New test modules/gitea/test/bundle-import.test.ts: with a forge that never answers, the import finishes within 3 s with the three tools registered (it hung on main). Try try-1792839666777566147 passed (2m25s).

Reviewed-by: review-handshake@shanks at 7afcd0282d
Pushed-by: lead-47@shanks

Issue 1726, note 26: when novox's tool runner was replaced at 12:37, gitea's watcher bundle waited at import for the forge's admin API (ensureSystemHook) past the 10 s handshake; the tool runner never starts a bundle again after a failed first handshake, so gitea_commit_status, gitea_merge_pull_request and gitea_events went unserved and no gitea.pull.* event reached the bus: no new pull request was announced, no status written. modules/gitea/index.ts no longer awaits the webhook set-up at import (void listenForForge(client)); its failure stays loud (gitea_events unhealthy, logged); the polls keep their 30 s pace until the webhook listens, so no pull event is missed. New test modules/gitea/test/bundle-import.test.ts: with a forge that never answers, the import finishes within 3 s with the three tools registered (it hung on main). Try try-1792839666777566147 passed (2m25s). Reviewed-by: review-handshake@shanks at 7afcd0282d62f0d4a95e1a9064931d754c6de8de Pushed-by: lead-47@shanks

mesh-tools added 1 commit 2026-10-24 11:09:13 +00:00

Set up the forge's webhook without holding the bundle's import, so a slow forge never costs gitea its handshake and its tools (issue 1726) 7afcd0282d

At 12:37 on 2026-10-24 node-tools on novox was replaced; gitea's watcher bundle awaited the webhook's set-up on the forge's admin API at the top of its import, outlasted the 10 s handshake and was killed, never to start again. gitea_commit_status, gitea_merge_pull_request and gitea_events were then served nowhere: the forge bridge's calls found no responders and no new pull request was announced.

jschoubben merged commit 545c72bb59 into main

2026-10-24 11:10:39 +00:00

jschoubben deleted branch fix/1726-gitea-handshake-not-on-forge

2026-10-24 11:10:40 +00:00

jschoubben referenced this issue from a commit

2026-10-24 11:30:44 +00:00

Merge main into feat/r4g-finish (#471)

jschoubben referenced this issue from a commit

2026-10-24 11:42:00 +00:00

Move source.main for a merge the gate caught up after a gap, so the checker re-checks open heads on the trunk that is (issue 1726)

mesh-tools referenced this pull request

2026-10-24 11:49:16 +00:00