mesh-delivery-gate asks the operator's Approve on a verdict only: the one-hour fallback goes (issue 1733) #555

Merged

mesh-tools merged 2 commits from fix/1733-no-hour into main 2026-10-28 21:29:53 +00:00

Conversation 1 Commits 2 Files Changed 5

+26 -87

mesh-tools commented 2026-10-28 20:50:23 +00:00

Member

Copy Link

Copy Source

Delivery group fix/1733-no-hour, with mesh-delivery fix/1733-no-hour.

Change. mesh-delivery-gate asks the operator's Approve when the check's verdict arrives, not after an hour without one: the one-hour ask bound and its caveat go (modules/mesh-delivery-gate: approval.go, holder.go, onestatus.go, ready.go, ready_test.go).

Why it is safe now. The paired mesh-delivery change makes the checker write a loud verdict on every path that used to leave a candidate without one (a member it cannot claim, a running verdict left for heads it cannot judge, a deleted verdict key), so no Approve waits silently.

Pushed-by: fix-lost@shanks
Reviewed-by: rev-l2@shanks at f37f93e812

Delivery group fix/1733-no-hour, with mesh-delivery fix/1733-no-hour. **Change.** mesh-delivery-gate asks the operator's Approve when the check's verdict arrives, not after an hour without one: the one-hour ask bound and its caveat go (modules/mesh-delivery-gate: approval.go, holder.go, onestatus.go, ready.go, ready_test.go). **Why it is safe now.** The paired mesh-delivery change makes the checker write a loud verdict on every path that used to leave a candidate without one (a member it cannot claim, a running verdict left for heads it cannot judge, a deleted verdict key), so no Approve waits silently. Pushed-by: fix-lost@shanks Reviewed-by: rev-l2@shanks at f37f93e812dfd8fd55280bf9aac22f3787538ec7

mesh-tools added 2 commits 2026-10-28 20:50:23 +00:00

Ask the Approve when the check's verdict arrives, not after an hour (issue 1733) cf4879eaa1

Drop the unreachable 'before its check ends' caveat (issue 1733) f37f93e812

mesh-tools commented 2026-10-28 20:50:26 +00:00

Author

Member

Copy Link

Copy Source

Delivery novox/mesh-catalog@f37f93e812df — merged since 2026-10-28T21:29:54Z

Source — source.main moved to novox/mesh-catalog@158348ede7. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Group fix/1733-no-hour: novox/mesh-catalog@f37f93e812, novox/mesh-delivery@2d8ad2e66a

• composed together: pass — the checker's verdict at the members' heads (f2aa87f2701d)

Transitions

• 2026-10-28 20:50 (new) → proposed (announced): novox/mesh-catalog#555's head announced
• 2026-10-28 20:50 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
• 2026-10-28 21:29 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-catalog@f37f93e812df` — **merged** since 2026-10-28T21:29:54Z **Source** — source.main moved to novox/mesh-catalog@158348ede789. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Group** `fix/1733-no-hour`: novox/mesh-catalog@f37f93e812df, novox/mesh-delivery@2d8ad2e66a8f - composed together: pass — the checker's verdict at the members' heads (f2aa87f2701d) **Transitions** - 2026-10-28 20:50 (new) → proposed (announced): novox/mesh-catalog#555's head announced - 2026-10-28 20:50 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-28 21:29 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.

mesh-tools merged commit 158348ede7 into main 2026-10-28 21:29:53 +00:00

mesh-tools deleted branch fix/1733-no-hour 2026-10-28 21:29:53 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

mesh/ready

Reviewed and ready: mesh-delivery merges at the marked head once its checks pass (hq ADR 0364)

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

agent-ace agent-g14 agent-novox agent-shanks jschoubben mesh-tools miel.truyen nox-agent

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-catalog#555