Archived
Say why assign finds no module, and keep an assignment pending on its build (hq issue 325) #150
Assignees
agent-ace
agent-g14
agent-novox
agent-shanks
jschoubben
mesh-tools
miel.truyen
nox-agent
Clear assignees
agent-ace
agent-g14
agent-novox
agent-shanks
jschoubben
mesh-tools
miel.truyen
nox-agent
No Assignees
No due date set.
Dependencies
No dependencies set.
Reference: novox/mesh-controller#150
Reference in New Issue
Block a user
hq issue 325 and ADR 0261 (novox/hq#214). Replay R325: novox/mesh-lab#68.
Rebased on main
056414b(after #144). Migration 0082 follows #144's 0081 (which only createsartifact_mirrored); no other open branch holds a migration above 0081. 0082 has never run on the live store, so the review's schema changes are made in it, not in a new number.Why
On 2026-10-08
assign g14 sensorsanswered "no module of that name" a minute after the merge that asked for the module's build (issue 300); minutes later it worked. The controller kept no record of a build it asked for until the outcome came back.What changes
build_request): kept once the ask is made, never before, with the real asker (merge,plan,build,assign,rebuild,replay); a request not handed over or not waited for is marked not-asked, unless its outcome was heard. Kept 30 days.assignof a module the catalogue does not hold says its case: in flight (no outcome within 2 h, or built within 5 min and being registered) keeps a pending assignment; known, not built refuses and offersbuildorbuild: "true"; unknown refuses, claiming only what it checked (the catalogue and the kept requests), with the closest names.build: "true"asks from the last request's source; a pending assignment already waiting is re-pointed to the new build, and no build is asked that nothing waits on.waitingtoapplying), the ordinaryassignact runs, then the final state is set.unassignof a claimed row is refused, never overridden. A claim left by a stopped controller is settled by the tick from what the mesh holds.settlingPending, started inserve) plus each build's outcome.status, the board, the summary and the probe only read.assignment-not-made(warning, operator), with plain words; it clears when the module is assigned there later, assigned again, or taken back withunassign.statusis not well only while a pending assignment is open; the condition carries the rest.Pending(zero)isstate = 'waiting';pending_assignment.nodeis a foreign key tonodewithon delete cascade.assignsends nothing: its note sayspush <node>sends it. No claim about the upgrade announcement remains.Tests
pending_test.go: in flight (answer, askermerge, status + JSON, build applying it); a status read settles nothing and the tick does; failed build expiring, its condition raised, read as known-not-built, cleared byunassign; cleared by a later assignment;build: "true"(askerassign); re-pointing a waiting row with one ask; a failed ask and a request not waited for never in flight, an outcome heard after still the last word; a plan's request kept asplan; a build being registered in flight, then expired past the grace; unknown wording; several-module act refused whole; withdraw then build makes nothing; a claim refused to unassign,Pending(zero)excluding it, a stale claim released or applied; silent build expiring; ended rows deleted after 30 days; seatbuild; plain words.internal/inventory/pending_test.go: a row goes with its machine.TestReplay325.sh merge-check.sh: exit 0 locally.Do not merge without the operator's approval.
Delivery
novox/mesh-controller@8adb7f1a0519— superseded since 2026-10-08T15:09:41ZDelivery plan — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step
Group
fix/assign-says-why-a-module-is-not-there, in order: novox/mesh-controller@8adb7f1a05 → novox/mesh-lab@33e63ee5b4Machines
Transitions
The commit's note under
refs/notes/mesh-plankeeps every transition:git log --notes=mesh-plan.Correction to the description's migration note: the store refuses a migration numbered below one already applied (
store.Pending). So whichever of #144 (0081) and this PR (0082) merges second must be the higher number: if this merges first, #144 renumbers its 0081 to 0083 before it merges; if #144 merges first, nothing changes here.Merge check at
b93dea8cmesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller, route-proxy)mesh/repo-check: PASS — its merge-check.sh passedDelivery plan — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step
Run by the build seat on g14 as
build-1791467365220841250(builds --log build-1791467365220841250).b93dea8c18todd78357b9bMerge check at
dd78357bmesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller, route-proxy)mesh/repo-check: PASS — its merge-check.sh passedDelivery plan — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step
Run by the build seat on ace as
build-1791469340723530258(builds --log build-1791469340723530258).dd78357b9bto8adb7f1a05Second review addressed at
8adb7f1, rebased on mainfe00fec(#151); 0082 still directly follows 0081.<node>.<module>.<row id>, one condition per pending assignment; a newer row answers an older one only while it is open or once it was made.unassigntakes back every unanswered row of that module on that machine.TestASecondAssignmentNotMadeKeepsItsConditionfollows the review's sequence; it fails on the old key and rule with "the second assignment's condition was cleared in the tick that raised it".ForgetEndedPendingkeeps a rowraised_at is null or cleared_at is not nullonly. A removed machine takes its rows (foreign key) and the tick clears any of their conditions still open (clearOrphaned). No verb removes a machine yet, so the test removes it as the store would.TestARaisedRowIsKeptUntilItsConditionClears.TestAStaleClaimIsSettledFromWhatTheMeshHolds, both branches, and a fresh claim left alone.link.ErrNotHandedOvernow marks a Submit that failed before the hand-over; only that is marked not asked. Any later failure isoutcome_unknown(asked, outcome unknown), read as in flight until its outcome or 2 h.TestABuildNoLongerWaitedForIsStillInFlight.sh merge-check.sh: exit 0 locally. R325 re-pointed in mesh-lab#68 and proved again.Merge check at
8adb7f1amesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller, route-proxy)mesh/repo-check: PASS — its merge-check.sh passedDelivery plan — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step
Run by the build seat on shanks as
build-1791470759146112587(builds --log build-1791470759146112587).