Test that plan --diff says a left-out module before the diff #182

Closed

mesh-admin wants to merge 1 commits from test/plan-diff-left-out-line into main

pull from: test/plan-diff-left-out-line

merge into: :main

:main

:fix/sweep-2026-10-30

:fix/checker-full-failure

:feat/1945-user-list-switch

:fix/1945-mesh-grants-publishes-memberships

:fix/issued-states-follow-the-module

:fix/1945-credential-on-assignment

:fix/r6-mirror-on-change

:fix/store-forge-address

:fix/r6-look-again-after-unlock

:fix/r6-key-waits-said

:fix/1931-reconnects-verb

:fix/forge-requires-no-status

:fix/906-lease-renewal

:feat/r4e-controller

:fix/1106-sdk-member-merges

:fix/1399-person-word-test

:fix/1652-checks-wait

:feat/files-through-the-store-files-verbs

:fix/1649-held-ask-handed-out-twice

:fix/1658-sdk-items

:fix/1334-a-bus-reload-fails-a-tier

:feat/chain-on-the-bus

:fix/701-a-name-nothing-answers-is-not-used

:fix/270-a-dead-bus-watch-is-heard

:fix/630-config-values-from-four-sources

:fix/613-node-smb-server

:feat/328-libraries-and-module-users

:feat/325-identities-and-kept-folders

:feat/bus-view-principal

:test/plan-diff-left-out-line

:fix/the-registry-trust-test-reads-the-runtimes-module

:fix/the-runtime-file-is-the-runtimes

:feat/build-edges-are-recorded

:fix/several-contributions-collide-in-grants-v2

Conversation 2 Commits 1 Files Changed 2

+37 -5

mesh-admin commented 2026-10-09 12:46:48 +00:00

Contributor

Copy Link

Copy Source

Follow-up of #181 (review nit). The diff path's left-out line moves into sayPlanDiff(node, declared, diff), which the verb calls with the real diff. A new test captures its output with printed() and checks that home: nfs-server left out, with the reason, comes before home: nothing would change.

Proved: if reportLeftOut is removed from sayPlanDiff, the test fails. merge-check.sh passes locally.

Not merged: waits for a person's approval.

Follow-up of #181 (review nit). The diff path's left-out line moves into `sayPlanDiff(node, declared, diff)`, which the verb calls with the real diff. A new test captures its output with `printed()` and checks that `home: nfs-server left out`, with the reason, comes before `home: nothing would change`. Proved: if `reportLeftOut` is removed from `sayPlanDiff`, the test fails. `merge-check.sh` passes locally. Not merged: waits for a person's approval.

mesh-admin added 1 commit 2026-10-09 12:46:48 +00:00

Test that plan --diff says a left-out module before the diff, through printed() 81f3c2d01b

mesh-admin commented 2026-10-09 12:47:15 +00:00

Author

Contributor

Copy Link

Copy Source

Delivery novox/mesh-controller@81f3c2d01b6c — stopped since 2026-10-17T19:44:11Z

Delivery plan — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step

• tier 0: mesh-controller
• tier 1: build-agent
• tier 2: route-proxy
• ace: receives build-agent, route-proxy
• g14: receives build-agent
• novox: receives mesh-controller, build-agent, route-proxy
• shanks: receives build-agent
• build-agent keeps data (ADR 0233): what it holds is backed up before it moves
• route-proxy provides route: its consumers are sent again after it
• route-proxy keeps data (ADR 0233): what it holds is backed up before it moves

Transitions

• 2026-10-09 12:47 (new) → proposed (announced): novox/mesh-controller#182's head announced
• 2026-10-09 12:58 proposed → checked (checked): the verdict names this commit
• 2026-10-09 12:58 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
• 2026-10-17 19:44 ready → stopped (closed): the pull request closed unmerged

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-controller@81f3c2d01b6c` — **stopped** since 2026-10-17T19:44:11Z **Delivery plan** — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - tier 2: route-proxy - ace: receives build-agent, route-proxy - g14: receives build-agent - novox: receives mesh-controller, build-agent, route-proxy - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - route-proxy provides route: its consumers are sent again after it - route-proxy keeps data (ADR 0233): what it holds is backed up before it moves **Transitions** - 2026-10-09 12:47 (new) → proposed (announced): novox/mesh-controller#182's head announced - 2026-10-09 12:58 proposed → checked (checked): the verdict names this commit - 2026-10-09 12:58 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-17 19:44 ready → stopped (closed): the pull request closed unmerged The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.

mesh-admin commented 2026-10-09 12:58:09 +00:00

Author

Contributor

Copy Link

Copy Source

Merge check at 81f3c2d0

• mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller, route-proxy)
• mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step

• tier 0: mesh-controller
• tier 1: build-agent
• tier 2: route-proxy
• ace: receives build-agent, route-proxy
• g14: receives build-agent
• novox: receives mesh-controller, build-agent, route-proxy
• shanks: receives build-agent
• build-agent keeps data (ADR 0233): what it holds is backed up before it moves
• route-proxy provides route: its consumers are sent again after it
• route-proxy keeps data (ADR 0233): what it holds is backed up before it moves

Run by the build seat on shanks as build-1791550034216526996 (builds --log build-1791550034216526996).

--- the gate: build-agent, mesh-controller, route-proxy
mesh-controller: ok, 52 tool(s); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 0
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-09T12:52:20Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-09T12:52:20Z

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 3 module(s) in 3 tier(s): build-agent, mesh-controller, route-proxy
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.043s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	209.199s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.041s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.043s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.053s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.212s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.091s
ok  	github.com/novox/mesh-controller/internal/broker	2.785s
ok  	github.com/novox/mesh-controller/internal/builder	2.058s
ok  	github.com/novox/mesh-controller/internal/catalogue	5.041s
ok  	github.com/novox/mesh-controller/internal/conditions	2.611s
ok  	github.com/novox/mesh-controller/internal/envfile	1.055s
ok  	github.com/novox/mesh-controller/internal/facts	1.081s
ok  	github.com/novox/mesh-controller/internal/identity	4.855s
ok  	github.com/novox/mesh-controller/internal/inventory	85.827s
ok  	github.com/novox/mesh-controller/internal/lease	17.708s
ok  	github.com/novox/mesh-controller/internal/licences	4.546s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.046s
ok  	github.com/novox/mesh-controller/internal/link	53.429s
ok  	github.com/novox/mesh-controller/internal/lint	2.225s
ok  	github.com/novox/mesh-controller/internal/outward	1.093s
ok  	github.com/novox/mesh-controller/internal/overlay	1.081s
ok  	github.com/novox/mesh-controller/internal/secrets	1.557s
ok  	github.com/novox/mesh-controller/internal/store	3.575s
ok  	github.com/novox/mesh-controller/internal/testbus	1.239s
ok  	github.com/novox/mesh-controller/internal/token	1.016s

**Merge check** at `81f3c2d0` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller, route-proxy) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - tier 2: route-proxy - ace: receives build-agent, route-proxy - g14: receives build-agent - novox: receives mesh-controller, build-agent, route-proxy - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - route-proxy provides route: its consumers are sent again after it - route-proxy keeps data (ADR 0233): what it holds is backed up before it moves Run by the build seat on shanks as `build-1791550034216526996` (`builds --log build-1791550034216526996`). ``` --- the gate: build-agent, mesh-controller, route-proxy mesh-controller: ok, 52 tool(s); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 0 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-09T12:52:20Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-09T12:52:20Z machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 3 module(s) in 3 tier(s): build-agent, mesh-controller, route-proxy --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.043s ok github.com/novox/mesh-controller/cmd/mesh-controller 209.199s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.041s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.043s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.053s ok github.com/novox/mesh-controller/examples/route-proxy 1.212s ok github.com/novox/mesh-controller/internal/artifacts 1.091s ok github.com/novox/mesh-controller/internal/broker 2.785s ok github.com/novox/mesh-controller/internal/builder 2.058s ok github.com/novox/mesh-controller/internal/catalogue 5.041s ok github.com/novox/mesh-controller/internal/conditions 2.611s ok github.com/novox/mesh-controller/internal/envfile 1.055s ok github.com/novox/mesh-controller/internal/facts 1.081s ok github.com/novox/mesh-controller/internal/identity 4.855s ok github.com/novox/mesh-controller/internal/inventory 85.827s ok github.com/novox/mesh-controller/internal/lease 17.708s ok github.com/novox/mesh-controller/internal/licences 4.546s ok github.com/novox/mesh-controller/internal/licences/adapters 1.046s ok github.com/novox/mesh-controller/internal/link 53.429s ok github.com/novox/mesh-controller/internal/lint 2.225s ok github.com/novox/mesh-controller/internal/outward 1.093s ok github.com/novox/mesh-controller/internal/overlay 1.081s ok github.com/novox/mesh-controller/internal/secrets 1.557s ok github.com/novox/mesh-controller/internal/store 3.575s ok github.com/novox/mesh-controller/internal/testbus 1.239s ok github.com/novox/mesh-controller/internal/token 1.016s ```

mesh-admin referenced this pull request 2026-10-12 10:12:13 +00:00

Keep a condition's looks in the store, so a look that changes nothing writes no bucket (issue 420) #249

mesh-admin referenced this pull request 2026-10-14 01:00:55 +00:00

57/F2: Placement leaves the settings layers, held beside the assignment (issue 651) #316

mesh-admin referenced this pull request 2026-10-14 06:07:35 +00:00

57/K2: The controller reads, judges against and keeps the catalogue's list of predefined keys (issue 661) #323

mesh-tools closed this pull request 2026-10-17 19:42:30 +00:00

This repo is archived. You cannot comment on pull requests.

Reviewers

No Reviewers

Labels

Clear labels

mesh/ready

Reviewed and ready: mesh-delivery merges at the marked head once its checks pass (hq ADR 0364)

No labels

Milestone

No items

No Milestone

Assignees

Clear assignees

agent-ace agent-g14 agent-novox agent-shanks jschoubben mesh-tools miel.truyen nox-agent

No Assignees

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-controller#182