Say a part waiting for the operator as needs-operator and pass its gate; add secret families (issue 386, ADR 0283) #209

Merged
mesh-admin merged 1 commits from feat/386-a-wait-for-the-operator into main 2026-10-10 19:49:30 +00:00
Contributor

Issue 386: a module whose only unhealthy part waited for an operator's secret failed its first-node gate, held every later walk, and told the operator there was nothing to do. hq ADR 0283 (novox/hq#294), decisions 3-6.

  • waiting state and waits on a resource's health (stored as JSON: no migration).
  • The wait check: a secret must be declared (by name or as a family member), issued outside the mesh, and not given on that machine; a setting must be declared. Otherwise the resource is judged unhealthy, saying why.
  • The first-node gate reads excused waits as waits for a person (ADR 0254): a pass carried in the verdict, for any build.
  • module.<m>.<machine>.needs-operator: warning, resolver operator, never escalated, raised on two statements, cleared on the first that does not say it; words name the act (the plain-words rule refuses the word agent, so needs reads "type at 's desk prompt."; ADR 0283 gets a dated insight for this).
  • Secret families <prefix>-*: issued outside, one * in the path, members [a-z0-9][a-z0-9-]*, never made by the mesh, placed only when given; a member not given composes.

No bus grant or subject changed. Harmless before the node-engine change (mesh-host#78): no engine says waiting yet. Follow-ups: issue 401, issue 405.

Reviewed by an independent reviewer at d5f6b67: approve, no blocking findings.

Issue 386: a module whose only unhealthy part waited for an operator's secret failed its first-node gate, held every later walk, and told the operator there was nothing to do. hq ADR 0283 (novox/hq#294), decisions 3-6. - `waiting` state and `waits` on a resource's health (stored as JSON: no migration). - The wait check: a secret must be declared (by name or as a family member), issued outside the mesh, and not given on that machine; a setting must be declared. Otherwise the resource is judged unhealthy, saying why. - The first-node gate reads excused waits as waits for a person (ADR 0254): a pass carried in the verdict, for any build. - `module.<m>.<machine>.needs-operator`: warning, resolver operator, never escalated, raised on two statements, cleared on the first that does not say it; words name the act (the plain-words rule refuses the word agent, so needs reads "type <what> at <machine>'s desk prompt."; ADR 0283 gets a dated insight for this). - Secret families `<prefix>-*`: issued outside, one `*` in the path, members `[a-z0-9][a-z0-9-]*`, never made by the mesh, placed only when given; a member not given composes. No bus grant or subject changed. Harmless before the node-engine change (mesh-host#78): no engine says `waiting` yet. Follow-ups: issue 401, issue 405. Reviewed by an independent reviewer at d5f6b67: approve, no blocking findings.
mesh-admin added 1 commit 2026-10-10 19:36:58 +00:00
Say a part waiting for the operator as needs-operator and pass its gate; add secret families (issue 386, hq ADR 0283)
mesh/merge-gate pass: builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step; every machine composes with the change as it did without …
mesh/repo-check pass: its merge-check.sh passed
mesh/delivery delivered
d5f6b67b94
A module waiting for the operator's secret failed its first-node gate, held
every later walk and was said as 'nothing for you to do'. The node-engine's
new waiting state is checked against the manifest and the secrets given,
read by the gate as a wait for a person, and raised as needs-operator naming
the act. A secret family gives each part its own one-line secret, which the
mesh never makes, so the desk prompt can take each password.
mesh-admin left a comment
Author
Contributor

Independent review (posted by the author agent; the reviewer reviewed the local commit before it was pushed): APPROVE at d5f6b67. go vet ./... passes; go test of cmd/mesh-controller, internal/catalogue, internal/conditions pass, and internal/inventory plus cmd/mesh-controller pass against a throwaway postgres 16. Decisions 3-6 of ADR 0283 correct; secret families sound (members [a-z0-9][a-z0-9-]*, never made, compose when none given); no secret value in events, conditions or verdicts; no bus grant, subject or migration changed. Non-blocking findings tracked as issue 405 (a waiting provider does not hold consumers; a wait beside relogin is hidden; secretsReadBy ignores members) plus: a second outward check on What, 'update in place' wording outside a delivery, and an end-to-end stateHealth test.

Independent review (posted by the author agent; the reviewer reviewed the local commit before it was pushed): APPROVE at d5f6b67. go vet ./... passes; go test of cmd/mesh-controller, internal/catalogue, internal/conditions pass, and internal/inventory plus cmd/mesh-controller pass against a throwaway postgres 16. Decisions 3-6 of ADR 0283 correct; secret families sound (members [a-z0-9][a-z0-9-]*, never made, compose when none given); no secret value in events, conditions or verdicts; no bus grant, subject or migration changed. Non-blocking findings tracked as issue 405 (a waiting provider does not hold consumers; a wait beside relogin is hidden; secretsReadBy ignores members) plus: a second outward check on What, 'update in place' wording outside a delivery, and an end-to-end stateHealth test.
Author
Contributor

Delivery novox/mesh-controller@d5f6b67b9498 — delivered since 2026-10-10T20:01:06Z

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves

Machines

  • mesh-controller on novox: passed — healthy 3 times over 3m36s
  • mesh-controller on the rest running it: sent
  • build-agent on ace: passed — healthy 3 times over 3m35s
  • build-agent on the rest running it: sent

Transitions

  • 2026-10-10 19:37 (new) → proposed (announced): novox/mesh-controller#209's head announced
  • 2026-10-10 19:43 proposed → checked (checked): the verdict names this commit
  • 2026-10-10 19:43 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-10 19:51 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-10 19:51 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
  • 2026-10-10 20:01 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-controller@d5f6b67b9498` — **delivered** since 2026-10-10T20:01:06Z **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves **Machines** - mesh-controller on novox: passed — healthy 3 times over 3m36s - mesh-controller on the rest running it: sent - build-agent on ace: passed — healthy 3 times over 3m35s - build-agent on the rest running it: sent **Transitions** - 2026-10-10 19:37 (new) → proposed (announced): novox/mesh-controller#209's head announced - 2026-10-10 19:43 proposed → checked (checked): the verdict names this commit - 2026-10-10 19:43 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-10 19:51 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-10 19:51 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit - 2026-10-10 20:01 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
Author
Contributor

Merge check at d5f6b67b

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • read by no module's build: cmd/mesh-controller/operator_wait_test.go, internal/catalogue/secret_family_test.go, internal/inventory/secret_family_test.go

Run by the build seat on shanks as build-1791661038756778589 (builds --log build-1791661038756778589).

--- the gate: build-agent, mesh-controller
mesh-controller: ok, 56 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-10T19:21:59Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-10T19:21:59Z

modules the change moves:
  - mesh-controller (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller

notes:
  - cmd/mesh-controller/operator_wait_test.go, internal/catalogue/secret_family_test.go and internal/inventory/secret_family_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.034s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	229.697s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.027s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.045s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.048s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.222s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.094s
ok  	github.com/novox/mesh-controller/internal/broker	2.836s
ok  	github.com/novox/mesh-controller/internal/builder	2.770s
ok  	github.com/novox/mesh-controller/internal/catalogue	5.094s
ok  	github.com/novox/mesh-controller/internal/conditions	2.578s
ok  	github.com/novox/mesh-controller/internal/envfile	1.072s
ok  	github.com/novox/mesh-controller/internal/facts	1.070s
ok  	github.com/novox/mesh-controller/internal/identity	4.780s
ok  	github.com/novox/mesh-controller/internal/inventory	90.687s
ok  	github.com/novox/mesh-controller/internal/lease	17.723s
ok  	github.com/novox/mesh-controller/internal/licences	4.339s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.062s
ok  	github.com/novox/mesh-controller/internal/link	54.011s
ok  	github.com/novox/mesh-controller/internal/lint	2.316s
ok  	github.com/novox/mesh-controller/internal/outward	1.091s
ok  	github.com/novox/mesh-controller/internal/overlay	1.079s
ok  	github.com/novox/mesh-controller/internal/secrets	1.532s
ok  	github.com/novox/mesh-controller/internal/store	3.465s
ok  	github.com/novox/mesh-controller/internal/testbus	1.252s
ok  	github.com/novox/mesh-controller/internal/token	1.014s
**Merge check** at `d5f6b67b` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - read by no module's build: cmd/mesh-controller/operator_wait_test.go, internal/catalogue/secret_family_test.go, internal/inventory/secret_family_test.go Run by the build seat on shanks as `build-1791661038756778589` (`builds --log build-1791661038756778589`). ``` --- the gate: build-agent, mesh-controller mesh-controller: ok, 56 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-10T19:21:59Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-10T19:21:59Z modules the change moves: - mesh-controller (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller notes: - cmd/mesh-controller/operator_wait_test.go, internal/catalogue/secret_family_test.go and internal/inventory/secret_family_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.034s ok github.com/novox/mesh-controller/cmd/mesh-controller 229.697s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.027s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.045s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.048s ok github.com/novox/mesh-controller/examples/route-proxy 1.222s ok github.com/novox/mesh-controller/internal/artifacts 1.094s ok github.com/novox/mesh-controller/internal/broker 2.836s ok github.com/novox/mesh-controller/internal/builder 2.770s ok github.com/novox/mesh-controller/internal/catalogue 5.094s ok github.com/novox/mesh-controller/internal/conditions 2.578s ok github.com/novox/mesh-controller/internal/envfile 1.072s ok github.com/novox/mesh-controller/internal/facts 1.070s ok github.com/novox/mesh-controller/internal/identity 4.780s ok github.com/novox/mesh-controller/internal/inventory 90.687s ok github.com/novox/mesh-controller/internal/lease 17.723s ok github.com/novox/mesh-controller/internal/licences 4.339s ok github.com/novox/mesh-controller/internal/licences/adapters 1.062s ok github.com/novox/mesh-controller/internal/link 54.011s ok github.com/novox/mesh-controller/internal/lint 2.316s ok github.com/novox/mesh-controller/internal/outward 1.091s ok github.com/novox/mesh-controller/internal/overlay 1.079s ok github.com/novox/mesh-controller/internal/secrets 1.532s ok github.com/novox/mesh-controller/internal/store 3.465s ok github.com/novox/mesh-controller/internal/testbus 1.252s ok github.com/novox/mesh-controller/internal/token 1.014s ```
mesh-admin merged commit dac7e5f7f6 into main 2026-10-10 19:49:30 +00:00
mesh-admin deleted branch feat/386-a-wait-for-the-operator 2026-10-10 19:49:30 +00:00
This repo is archived. You cannot comment on pull requests.
No Reviewers
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-controller#209