Let plans wait for a plan to move and answer it as data (issue 229) #266

Merged
mesh-admin merged 2 commits from fix/229-plans-wait into main 2026-10-12 17:06:51 +00:00
Contributor

What. mesh-controller.plans takes wait (a plan's id), until (moved, the default; tier; done) and bound (15s or seconds; at most and by default 20s). It answers when the plan moves, reaches another tier or ends, or when the bound passes, and says which in came (moved, tier, done, bound). The answer is data: answer carries came, until, waited, revision and the plan as status says it (planStatus); the output is the plan's line in prose, never JSON inside a string (the queue pattern, tableBesideVerbs). A plan that has already ended answers done at once, and an ended plan ends every wait.

Why. Issue 229, decided 2026-10-11 (part 1, waiting, and part 2 for plans): an agent following a rollout had plans answer once, in prose, and wrote a curl loop round the console to be told a plan moved.

How the wait fits a call. A seat call's one answer must reach the console inside its 30 seconds (mesh-tools RequestTimeout), and the controller answered "still running" after AnswerWithin (10s). link.AnswersWithin(ctx, d) lets a handler that waits on purpose hold its answer up to d, capped at link.LongestAnswer (25s, inside the console's 30s and the bus's ResponseTTL). The plans handler asks for its bound plus 5s for starting the command. Past that, the caller is told it is running, as for any call.

Design limit I chose. The decision said "a bound of at most 10 minutes" and also "no verb waits longer than the console's call timeout". The second rule decides it: the bound is at most 20s. To follow a plan to its end, a caller asks again, and each call answers the moment the plan moves. moved and tier are judged against the plan as the call first reads it, and the answer carries revision so a caller can see moves between calls. The wait reads the store once a second.

Not in this PR (still open under issue 229): waiting on a node's report (node … wait applied), data answers for builds and calls, a name filter on modules (the verb exists; it runs module list --json, but module is not in jsonVerbs, so I think its answer is not parsed as data, which I did not check live), mesh-delivery's checks (hq #250 note), and the console's listChanged (mesh-tools).

Tests.

  • internal/link/calls_wait_test.go: a handler that asks for a window is answered in full past AnswerWithin. This test fails with AnswersWithin made a no-op: the caller is answered "running". A handler asking for an hour is still answered "running" at LongestAnswer.
  • cmd/mesh-controller/plans_follow_test.go: moved, tier and done each end the wait at the right read. An ended plan ends every wait. The bound is enforced. Bad until or bound values are refused. The answer is data with its prose beside it. The verb composes plans wait <id> --until --bound, and refuses until without wait and a bound over 20s.
  • Store-backed TestAPlanFollowedFromTheStoreAnswersWhenItMoves (added to testdata/store-tests): the real command answers tier about 1.5s after another writer moves the plan, and answers bound when nothing moves.
  • sh merge-check.sh against a throwaway PostgreSQL 18 passes locally: gofmt, vet, go test -race ./..., and every listed store test.

Files. No file is shared with #262–#265. Each of #401 and this PR adds a line to testdata/store-tests, at different places in the file.

Order. A controller rollout: merge only while mesh-controller.plans says done. The verb's new arguments reach the seat's row with this build.

Part of issue 229 (waiting on plans, and plans answering as data). Not merged.

**What.** `mesh-controller.plans` takes `wait` (a plan's id), `until` (`moved`, the default; `tier`; `done`) and `bound` (`15s` or seconds; at most and by default 20s). It answers when the plan moves, reaches another tier or ends, or when the bound passes, and says which in `came` (`moved`, `tier`, `done`, `bound`). The answer is data: `answer` carries `came`, `until`, `waited`, `revision` and the plan as `status` says it (`planStatus`); the output is the plan's line in prose, never JSON inside a string (the `queue` pattern, `tableBesideVerbs`). A plan that has already ended answers `done` at once, and an ended plan ends every wait. **Why.** Issue 229, decided 2026-10-11 (part 1, waiting, and part 2 for `plans`): an agent following a rollout had `plans` answer once, in prose, and wrote a curl loop round the console to be told a plan moved. **How the wait fits a call.** A seat call's one answer must reach the console inside its 30 seconds (mesh-tools `RequestTimeout`), and the controller answered "still running" after `AnswerWithin` (10s). `link.AnswersWithin(ctx, d)` lets a handler that waits on purpose hold its answer up to `d`, capped at `link.LongestAnswer` (25s, inside the console's 30s and the bus's `ResponseTTL`). The `plans` handler asks for its bound plus 5s for starting the command. Past that, the caller is told it is running, as for any call. **Design limit I chose.** The decision said "a bound of at most 10 minutes" and also "no verb waits longer than the console's call timeout". The second rule decides it: the bound is at most 20s. To follow a plan to its end, a caller asks again, and each call answers the moment the plan moves. `moved` and `tier` are judged against the plan as the call first reads it, and the answer carries `revision` so a caller can see moves between calls. The wait reads the store once a second. **Not in this PR** (still open under issue 229): waiting on a node's report (`node … wait applied`), data answers for `builds` and `calls`, a name filter on `modules` (the verb exists; it runs `module list --json`, but `module` is not in `jsonVerbs`, so I think its answer is not parsed as data, which I did not check live), mesh-delivery's checks (hq #250 note), and the console's `listChanged` (mesh-tools). **Tests.** - `internal/link/calls_wait_test.go`: a handler that asks for a window is answered in full past `AnswerWithin`. This test fails with `AnswersWithin` made a no-op: the caller is answered "running". A handler asking for an hour is still answered "running" at `LongestAnswer`. - `cmd/mesh-controller/plans_follow_test.go`: `moved`, `tier` and `done` each end the wait at the right read. An ended plan ends every wait. The bound is enforced. Bad `until` or `bound` values are refused. The answer is data with its prose beside it. The verb composes `plans wait <id> --until --bound`, and refuses `until` without `wait` and a bound over 20s. - Store-backed `TestAPlanFollowedFromTheStoreAnswersWhenItMoves` (added to `testdata/store-tests`): the real command answers `tier` about 1.5s after another writer moves the plan, and answers `bound` when nothing moves. - `sh merge-check.sh` against a throwaway PostgreSQL 18 passes locally: gofmt, vet, `go test -race ./...`, and every listed store test. **Files.** No file is shared with #262–#265. Each of #401 and this PR adds a line to `testdata/store-tests`, at different places in the file. **Order.** A controller rollout: merge only while `mesh-controller.plans` says done. The verb's new arguments reach the seat's row with this build. Part of issue 229 (waiting on plans, and `plans` answering as data). Not merged.
mesh-admin added 1 commit 2026-10-12 14:19:10 +00:00
Let plans wait for a plan to move and answer it as data (issue 229)
mesh/merge-gate pass: builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step; every machine composes with the change as it did without …
mesh/repo-check pass: its merge-check.sh passed
mesh/delivery superseded: a newer head of the same pull request
d20b52cb19
An agent following a rollout had plans answer once, in prose, and polled the
console with a curl loop of its own to be told a plan moved. plans now takes
wait (a plan's id), until (moved, tier or done) and bound, and answers when the
plan moves or the bound passes, saying which, with the plan as data and its
line as the output.

A call's one answer has to reach the console inside its thirty seconds, so
link.AnswersWithin lets a handler that waits on purpose hold its answer up to
LongestAnswer (25s) instead of AnswerWithin; the bound is at most 20s, and a
caller following a plan further asks again.
Author
Contributor

Delivery novox/mesh-controller@5ad36127ee8b — delivered since 2026-10-12T17:15:50Z

Delivery plan — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • tier 2: route-proxy
  • ace: receives build-agent, route-proxy
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent, route-proxy
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • route-proxy provides route: its consumers are sent again after it
  • route-proxy keeps data (ADR 0233): what it holds is backed up before it moves
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent, route-proxy is judged on its first machine

Machines

  • mesh-controller on novox: passed — healthy 3 times over 4m9s
  • mesh-controller on the rest running it: sent
  • build-agent on ace: passed — healthy 1 times over 1m24s
  • build-agent on the rest running it: sent

Transitions

  • 2026-10-12 14:51 (new) → proposed (announced): novox/mesh-controller#266's head announced
  • 2026-10-12 15:01 proposed → checked (checked): the verdict names this commit
  • 2026-10-12 15:01 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-12 17:07 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-12 17:07 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
  • 2026-10-12 17:15 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-controller@5ad36127ee8b` — **delivered** since 2026-10-12T17:15:50Z **Delivery plan** — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - tier 2: route-proxy - ace: receives build-agent, route-proxy - g14: receives build-agent - novox: receives mesh-controller, build-agent, route-proxy - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - route-proxy provides route: its consumers are sent again after it - route-proxy keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent, route-proxy is judged on its first machine **Machines** - mesh-controller on novox: passed — healthy 3 times over 4m9s - mesh-controller on the rest running it: sent - build-agent on ace: passed — healthy 1 times over 1m24s - build-agent on the rest running it: sent **Transitions** - 2026-10-12 14:51 (new) → proposed (announced): novox/mesh-controller#266's head announced - 2026-10-12 15:01 proposed → checked (checked): the verdict names this commit - 2026-10-12 15:01 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-12 17:07 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-12 17:07 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit - 2026-10-12 17:15 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
Author
Contributor

Merge check at d20b52cb

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine
  • read by no module's build: cmd/mesh-controller/plans_follow_test.go, internal/link/calls_wait_test.go, testdata/store-tests

Run by the build seat on ace as build-1791814777413893421 (builds --log build-1791814777413893421).

--- the gate: build-agent, mesh-controller
mesh-controller: ok, 58 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T14:13:26Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-12T14:13:26Z

modules the change moves:
  - mesh-controller (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller

notes:
  - cmd/mesh-controller/plans_follow_test.go, internal/link/calls_wait_test.go and testdata/store-tests read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.034s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	258.809s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.014s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.022s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.013s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.131s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.052s
?   	github.com/novox/mesh-controller/internal/beside	[no test files]
ok  	github.com/novox/mesh-controller/internal/broker	4.109s
ok  	github.com/novox/mesh-controller/internal/builder	35.405s
ok  	github.com/novox/mesh-controller/internal/catalogue	7.810s
ok  	github.com/novox/mesh-controller/internal/conditions	2.630s
ok  	github.com/novox/mesh-controller/internal/envfile	1.044s
ok  	github.com/novox/mesh-controller/internal/facts	1.047s
ok  	github.com/novox/mesh-controller/internal/identity	4.583s
ok  	github.com/novox/mesh-controller/internal/inventory	94.458s
ok  	github.com/novox/mesh-controller/internal/lease	17.724s
ok  	github.com/novox/mesh-controller/internal/licences	4.185s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.073s
ok  	github.com/novox/mesh-controller/internal/link	60.548s
ok  	github.com/novox/mesh-controller/internal/lint	2.292s
ok  	github.com/novox/mesh-controller/internal/outward	1.127s
ok  	github.com/novox/mesh-controller/internal/overlay	1.064s
ok  	github.com/novox/mesh-controller/internal/secrets	1.457s
ok  	github.com/novox/mesh-controller/internal/store	3.474s
ok  	github.com/novox/mesh-controller/internal/testbus	1.272s
ok  	github.com/novox/mesh-controller/internal/token	1.020s
store tests, each run against the store:
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.42s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.44s)
  ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.42s)
  ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.39s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.40s)
  ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.39s)
  ./cmd/mesh-controller --- PASS: TestAPlanFollowedFromTheStoreAnswersWhenItMoves (4.36s)
  ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.46s)
  ./cmd/mesh-controller --- PASS: TestTheConditionsVerbReadsTheLooksTheBucketNoLongerHolds (0.32s)
  ./cmd/mesh-controller --- PASS: TestAWalkLetGoAndStoppedByVerbsIsSaidStartedAndEnded (0.46s)
  ./cmd/mesh-controller --- PASS: TestAWalkStoppedOrClosedByAPersonIsSaidEndedStopped (0.45s)
  ./cmd/mesh-controller --- PASS: TestAWalkRetriedByAPersonIsSaidStartedAgain (0.40s)
  ./cmd/mesh-controller --- PASS: TestABacklogReleasedByAPersonIsSaidStarted (0.39s)
  ./cmd/mesh-controller --- PASS: TestAWalkEndedByCancelOrClearIsSaidEnded (0.46s)
  ./cmd/mesh-controller --- PASS: TestAWalkRestartedByARebuildIsSaidStarted (0.40s)
  ./cmd/mesh-controller --- PASS: TestAWalkStoppedByHandAndRetriedEndsFailedWhenItFailsAgain (0.45s)
  ./cmd/mesh-controller --- PASS: TestReplay237 (0.41s)
  ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeUnresolvedSaysSoOnceInItsAnswer (0.43s)
  ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeResolvedSaysNothingOfIt (0.43s)
  ./cmd/mesh-controller --- PASS: TestAnAssignThatLeavesItsNodeUnresolvedSaysOnlyThePlansRefusal (0.41s)
  ./cmd/mesh-controller --- PASS: TestADirectoryOwnersKeyIsRefusedThroughAVerb (0.43s)
  ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.26s)
  ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.25s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.26s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.27s)
  ./internal/inventory --- PASS: TestAConditionsLooksAreKeptBesideTheBucket (0.24s)
  ./internal/inventory --- PASS: TestAWalksStartIsKeptAndARefusedSaveLeavesItUnsaid (0.24s)
**Merge check** at `d20b52cb` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine - read by no module's build: cmd/mesh-controller/plans_follow_test.go, internal/link/calls_wait_test.go, testdata/store-tests Run by the build seat on ace as `build-1791814777413893421` (`builds --log build-1791814777413893421`). ``` --- the gate: build-agent, mesh-controller mesh-controller: ok, 58 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T14:13:26Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-12T14:13:26Z modules the change moves: - mesh-controller (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller notes: - cmd/mesh-controller/plans_follow_test.go, internal/link/calls_wait_test.go and testdata/store-tests read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.034s ok github.com/novox/mesh-controller/cmd/mesh-controller 258.809s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.014s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.022s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.013s ok github.com/novox/mesh-controller/examples/route-proxy 1.131s ok github.com/novox/mesh-controller/internal/artifacts 1.052s ? github.com/novox/mesh-controller/internal/beside [no test files] ok github.com/novox/mesh-controller/internal/broker 4.109s ok github.com/novox/mesh-controller/internal/builder 35.405s ok github.com/novox/mesh-controller/internal/catalogue 7.810s ok github.com/novox/mesh-controller/internal/conditions 2.630s ok github.com/novox/mesh-controller/internal/envfile 1.044s ok github.com/novox/mesh-controller/internal/facts 1.047s ok github.com/novox/mesh-controller/internal/identity 4.583s ok github.com/novox/mesh-controller/internal/inventory 94.458s ok github.com/novox/mesh-controller/internal/lease 17.724s ok github.com/novox/mesh-controller/internal/licences 4.185s ok github.com/novox/mesh-controller/internal/licences/adapters 1.073s ok github.com/novox/mesh-controller/internal/link 60.548s ok github.com/novox/mesh-controller/internal/lint 2.292s ok github.com/novox/mesh-controller/internal/outward 1.127s ok github.com/novox/mesh-controller/internal/overlay 1.064s ok github.com/novox/mesh-controller/internal/secrets 1.457s ok github.com/novox/mesh-controller/internal/store 3.474s ok github.com/novox/mesh-controller/internal/testbus 1.272s ok github.com/novox/mesh-controller/internal/token 1.020s store tests, each run against the store: ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.42s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.44s) ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.42s) ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.39s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.40s) ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.39s) ./cmd/mesh-controller --- PASS: TestAPlanFollowedFromTheStoreAnswersWhenItMoves (4.36s) ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.46s) ./cmd/mesh-controller --- PASS: TestTheConditionsVerbReadsTheLooksTheBucketNoLongerHolds (0.32s) ./cmd/mesh-controller --- PASS: TestAWalkLetGoAndStoppedByVerbsIsSaidStartedAndEnded (0.46s) ./cmd/mesh-controller --- PASS: TestAWalkStoppedOrClosedByAPersonIsSaidEndedStopped (0.45s) ./cmd/mesh-controller --- PASS: TestAWalkRetriedByAPersonIsSaidStartedAgain (0.40s) ./cmd/mesh-controller --- PASS: TestABacklogReleasedByAPersonIsSaidStarted (0.39s) ./cmd/mesh-controller --- PASS: TestAWalkEndedByCancelOrClearIsSaidEnded (0.46s) ./cmd/mesh-controller --- PASS: TestAWalkRestartedByARebuildIsSaidStarted (0.40s) ./cmd/mesh-controller --- PASS: TestAWalkStoppedByHandAndRetriedEndsFailedWhenItFailsAgain (0.45s) ./cmd/mesh-controller --- PASS: TestReplay237 (0.41s) ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeUnresolvedSaysSoOnceInItsAnswer (0.43s) ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeResolvedSaysNothingOfIt (0.43s) ./cmd/mesh-controller --- PASS: TestAnAssignThatLeavesItsNodeUnresolvedSaysOnlyThePlansRefusal (0.41s) ./cmd/mesh-controller --- PASS: TestADirectoryOwnersKeyIsRefusedThroughAVerb (0.43s) ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.26s) ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.25s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.26s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.27s) ./internal/inventory --- PASS: TestAConditionsLooksAreKeptBesideTheBucket (0.24s) ./internal/inventory --- PASS: TestAWalksStartIsKeptAndARefusedSaveLeavesItUnsaid (0.24s) ```
mesh-admin left a comment
Author
Contributor

Verdict: request changes at d20b52cb19

Independent review for issue 229, part 1 (plans wait/until/bound). One blocking finding; the rest is sound.

Blocking

  1. The wait id reaches SQL unchecked. plans wait passes its value through commandLine (seatverbs.go) to planWaitCommand → inv.PlanByID, which builds where id = ' + id + ' (internal/inventory/plans.go:643). Nothing checks the id's shape on the way: wait: "x' or '1'='1" reads an arbitrary plan, and a union select … reads other tables of the controller's store into the answer — now once a second for up to 20s. The same hole already exists for id, stop, close, retry, go; this PR adds a new path to it. Fix at least for wait (better: once, for every plan-id argument, and ideally a $1 parameter in PlanByID): refuse an id not matching ^(plan|release)-[0-9]+$ in commandLine, with a sentence naming the shape, and a test that a quoted id is refused before a command starts.

Checked and fine

  • Matches the note's part (1) for plans: wait with an id, until moved|tier|done, a bound, the answer says what ended it (moved/tier/done/bound). The 20s cap is a sound reading of "no verb waits longer than the console's call timeout": mesh-tools' launch.CallTimeout and bus.RequestTimeout are both 30s, LongestAnswer is 25s (20s bound + 5s start/compose), and broker.ResponseTTL is 1 minute. Not in this PR, and to stay open on the issue: the node-report wait (node … wait applied), part (2) for the other verbs, and the mesh-delivery check wait the 2026-10-11 note asks for.
  • AnswersWithin only stretches a window a handler asks for, never shortens it, is capped at LongestAnswer, and is a no-op outside a served call; the buffered, non-blocking send cannot block or leak after the caller was answered. A handler that never calls it takes the old path unchanged (AnswerWithin 10s, then "still running"). Go 1.26 timers make the Reset safe even when the timer fired in the same select.
  • Wait loop: one PlanByID per second per waiter, each waiter a command of its own already bounded to 20s — acceptable load. Exits on ctx cancel, on a plan ending (any until), and an unknown id fails on the first read with "no plan X", not after 20s. If the caller goes away the command still runs to its bound at most; bounded, so no leak.
  • Answer shape: like queue's — the doc's text becomes the output, the rest the answer. Old plans forms (list, one plan, what-if, stop/close/retry/go) print text, so they parse as no JSON and answer exactly as before. until/bound without wait are refused by the unused-argument check.
  • Tests fail without the fix: with main's calls.go and a no-op AnswersWithin stub, TestAHandlerThatWaitsOnPurposeIsAnsweredInFullInsideItsWindow fails (answered running at 20ms). The store test TestAPlanFollowedFromTheStoreAnswersWhenItMoves is listed in testdata/store-tests and passed against a live store.
  • Ran: go vet ./... clean; targeted go test -race on internal/link and cmd/mesh-controller pass; merge-check.sh with a throwaway Postgres 18 (MESH_TEST_POSTGRES) exits 0 under -race, every listed store test PASS.
  • Statuses on the head: mesh/merge-gate success (every machine composes), mesh/repo-check success, mesh/delivery success (ready). Mergeable.

Minor (not blocking)

  • The schema text hard-codes "20s"; it is derived (LongestAnswer − planWaitStart), so say it from the value or keep a test that the two agree.
  • A slow store could push read+compose past the 5s margin; the caller then gets "still running" and follows by calls, which degrades correctly — worth a sentence in the comment.
Verdict: request changes at d20b52cb196b0fbbeb885e830e50d22e1b68b8cc Independent review for issue 229, part 1 (plans wait/until/bound). One blocking finding; the rest is sound. ## Blocking 1. **The wait id reaches SQL unchecked.** `plans` `wait` passes its value through `commandLine` (seatverbs.go) to `planWaitCommand` → `inv.PlanByID`, which builds `where id = '` + id + `'` (internal/inventory/plans.go:643). Nothing checks the id's shape on the way: `wait: "x' or '1'='1"` reads an arbitrary plan, and a `union select …` reads other tables of the controller's store into the answer — now once a second for up to 20s. The same hole already exists for `id`, `stop`, `close`, `retry`, `go`; this PR adds a new path to it. Fix at least for wait (better: once, for every plan-id argument, and ideally a `$1` parameter in PlanByID): refuse an id not matching `^(plan|release)-[0-9]+$` in `commandLine`, with a sentence naming the shape, and a test that a quoted id is refused before a command starts. ## Checked and fine - **Matches the note's part (1)** for plans: wait with an id, until moved|tier|done, a bound, the answer says what ended it (moved/tier/done/bound). The 20s cap is a sound reading of "no verb waits longer than the console's call timeout": mesh-tools' `launch.CallTimeout` and `bus.RequestTimeout` are both 30s, `LongestAnswer` is 25s (20s bound + 5s start/compose), and broker.ResponseTTL is 1 minute. Not in this PR, and to stay open on the issue: the node-report wait (`node … wait applied`), part (2) for the other verbs, and the mesh-delivery check wait the 2026-10-11 note asks for. - **AnswersWithin** only stretches a window a handler asks for, never shortens it, is capped at LongestAnswer, and is a no-op outside a served call; the buffered, non-blocking send cannot block or leak after the caller was answered. A handler that never calls it takes the old path unchanged (AnswerWithin 10s, then "still running"). Go 1.26 timers make the `Reset` safe even when the timer fired in the same select. - **Wait loop**: one `PlanByID` per second per waiter, each waiter a command of its own already bounded to 20s — acceptable load. Exits on ctx cancel, on a plan ending (any until), and an unknown id fails on the first read with "no plan X", not after 20s. If the caller goes away the command still runs to its bound at most; bounded, so no leak. - **Answer shape**: like `queue`'s — the doc's `text` becomes the output, the rest the `answer`. Old `plans` forms (list, one plan, what-if, stop/close/retry/go) print text, so they parse as no JSON and answer exactly as before. `until`/`bound` without `wait` are refused by the unused-argument check. - **Tests fail without the fix**: with main's calls.go and a no-op AnswersWithin stub, TestAHandlerThatWaitsOnPurposeIsAnsweredInFullInsideItsWindow fails (answered running at 20ms). The store test TestAPlanFollowedFromTheStoreAnswersWhenItMoves is listed in testdata/store-tests and passed against a live store. - **Ran**: `go vet ./...` clean; targeted `go test -race` on internal/link and cmd/mesh-controller pass; `merge-check.sh` with a throwaway Postgres 18 (MESH_TEST_POSTGRES) exits 0 under -race, every listed store test PASS. - **Statuses on the head**: mesh/merge-gate success (every machine composes), mesh/repo-check success, mesh/delivery success (ready). Mergeable. ## Minor (not blocking) - The schema text hard-codes "20s"; it is derived (LongestAnswer − planWaitStart), so say it from the value or keep a test that the two agree. - A slow store could push read+compose past the 5s margin; the caller then gets "still running" and follows by `calls`, which degrades correctly — worth a sentence in the comment.
jschoubben added 1 commit 2026-10-12 14:51:03 +00:00
Hold the plans schema's longest bound to the value, and say what a slow store gives (review 75)
mesh/merge-gate head 5ad36127ee8b merged into trunk f8daec01d3f0 — pass: builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step; every …
mesh/repo-check head 5ad36127ee8b merged into trunk f8daec01d3f0 — pass: its merge-check.sh passed
mesh/delivery delivered
5ad36127ee
Author
Contributor

Review 75:

  • Blocking point (the wait id reaches SQL). Fixed at the root in #268 (issue 561). PlanByID and RecentPlans now take $1 parameters. commandLine also refuses every plan-id argument of plans (id, wait, stop, close, retry, go) that does not match ^(plan|release)-[0-9]+$, before any command starts. wait is in that list, so the check covers this PR once both are merged. git merge-tree merges #266 and #268 cleanly. Merge #268 before this one.
  • Minor points. Commit 5ad36127 adds TestThePlansSchemaSaysTheLongestBoundThereIs, which holds the schema's "20s" to maxPlanWait and fails if either changes alone. It also adds a comment on planWaitStart: a store slow enough to push past the margin makes the caller read "still running", and calls with the call's id gives the result. merge-check.sh against a throwaway Postgres passes locally.
Review 75: - **Blocking point (the wait id reaches SQL).** Fixed at the root in #268 (issue 561). `PlanByID` and `RecentPlans` now take `$1` parameters. `commandLine` also refuses every plan-id argument of `plans` (`id`, `wait`, `stop`, `close`, `retry`, `go`) that does not match `^(plan|release)-[0-9]+$`, before any command starts. `wait` is in that list, so the check covers this PR once both are merged. `git merge-tree` merges #266 and #268 cleanly. **Merge #268 before this one.** - **Minor points.** Commit 5ad36127 adds `TestThePlansSchemaSaysTheLongestBoundThereIs`, which holds the schema's "20s" to `maxPlanWait` and fails if either changes alone. It also adds a comment on `planWaitStart`: a store slow enough to push past the margin makes the caller read "still running", and `calls` with the call's id gives the result. `merge-check.sh` against a throwaway Postgres passes locally.
Author
Contributor

Merge check at 5ad36127

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller, route-proxy)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • tier 2: route-proxy
  • ace: receives build-agent, route-proxy
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent, route-proxy
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • route-proxy provides route: its consumers are sent again after it
  • route-proxy keeps data (ADR 0233): what it holds is backed up before it moves
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent, route-proxy is judged on its first machine

Run by the build seat on novox as build-1791816669516385960 (builds --log build-1791816669516385960).

--- the gate: build-agent, mesh-controller, route-proxy
mesh-controller: ok, 58 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T14:44:57Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-12T14:44:57Z

modules the change moves:
  - mesh-controller (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 3 module(s) in 3 tier(s): build-agent, mesh-controller, route-proxy
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.053s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	350.563s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.018s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.031s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.019s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.122s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.063s
?   	github.com/novox/mesh-controller/internal/beside	[no test files]
ok  	github.com/novox/mesh-controller/internal/broker	4.886s
ok  	github.com/novox/mesh-controller/internal/builder	49.888s
ok  	github.com/novox/mesh-controller/internal/catalogue	9.632s
ok  	github.com/novox/mesh-controller/internal/conditions	2.649s
ok  	github.com/novox/mesh-controller/internal/envfile	1.024s
ok  	github.com/novox/mesh-controller/internal/facts	1.030s
ok  	github.com/novox/mesh-controller/internal/identity	6.168s
ok  	github.com/novox/mesh-controller/internal/inventory	137.104s
ok  	github.com/novox/mesh-controller/internal/lease	17.630s
ok  	github.com/novox/mesh-controller/internal/licences	5.237s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.015s
ok  	github.com/novox/mesh-controller/internal/link	69.381s
ok  	github.com/novox/mesh-controller/internal/lint	2.699s
ok  	github.com/novox/mesh-controller/internal/outward	1.054s
ok  	github.com/novox/mesh-controller/internal/overlay	1.033s
ok  	github.com/novox/mesh-controller/internal/secrets	1.541s
ok  	github.com/novox/mesh-controller/internal/store	3.687s
ok  	github.com/novox/mesh-controller/internal/testbus	1.307s
ok  	github.com/novox/mesh-controller/internal/token	1.025s
store tests, each run against the store:
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.47s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.48s)
  ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.45s)
  ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.46s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.43s)
  ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.42s)
  ./cmd/mesh-controller --- PASS: TestAPlanFollowedFromTheStoreAnswersWhenItMoves (4.96s)
  ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.55s)
  ./cmd/mesh-controller --- PASS: TestTheConditionsVerbReadsTheLooksTheBucketNoLongerHolds (0.41s)
  ./cmd/mesh-controller --- PASS: TestAWalkLetGoAndStoppedByVerbsIsSaidStartedAndEnded (0.63s)
  ./cmd/mesh-controller --- PASS: TestAWalkStoppedOrClosedByAPersonIsSaidEndedStopped (0.52s)
  ./cmd/mesh-controller --- PASS: TestAWalkRetriedByAPersonIsSaidStartedAgain (0.48s)
  ./cmd/mesh-controller --- PASS: TestABacklogReleasedByAPersonIsSaidStarted (0.48s)
  ./cmd/mesh-controller --- PASS: TestAWalkEndedByCancelOrClearIsSaidEnded (0.54s)
  ./cmd/mesh-controller --- PASS: TestAWalkRestartedByARebuildIsSaidStarted (0.51s)
  ./cmd/mesh-controller --- PASS: TestAWalkStoppedByHandAndRetriedEndsFailedWhenItFailsAgain (0.49s)
  ./cmd/mesh-controller --- PASS: TestReplay237 (1.78s)
  ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeUnresolvedSaysSoOnceInItsAnswer (0.42s)
  ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeResolvedSaysNothingOfIt (0.43s)
  ./cmd/mesh-controller --- PASS: TestAnAssignThatLeavesItsNodeUnresolvedSaysOnlyThePlansRefusal (0.44s)
  ./cmd/mesh-controller --- PASS: TestADirectoryOwnersKeyIsRefusedThroughAVerb (1.70s)
  ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.28s)
  ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.28s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.30s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.29s)
  ./internal/inventory --- PASS: TestAConditionsLooksAreKeptBesideTheBucket (0.27s)
  ./internal/inventory --- PASS: TestAWalksStartIsKeptAndARefusedSaveLeavesItUnsaid (0.28s)
**Merge check** at `5ad36127` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller, route-proxy) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - tier 2: route-proxy - ace: receives build-agent, route-proxy - g14: receives build-agent - novox: receives mesh-controller, build-agent, route-proxy - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - route-proxy provides route: its consumers are sent again after it - route-proxy keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent, route-proxy is judged on its first machine Run by the build seat on novox as `build-1791816669516385960` (`builds --log build-1791816669516385960`). ``` --- the gate: build-agent, mesh-controller, route-proxy mesh-controller: ok, 58 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T14:44:57Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-12T14:44:57Z modules the change moves: - mesh-controller (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 3 module(s) in 3 tier(s): build-agent, mesh-controller, route-proxy --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.053s ok github.com/novox/mesh-controller/cmd/mesh-controller 350.563s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.018s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.031s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.019s ok github.com/novox/mesh-controller/examples/route-proxy 1.122s ok github.com/novox/mesh-controller/internal/artifacts 1.063s ? github.com/novox/mesh-controller/internal/beside [no test files] ok github.com/novox/mesh-controller/internal/broker 4.886s ok github.com/novox/mesh-controller/internal/builder 49.888s ok github.com/novox/mesh-controller/internal/catalogue 9.632s ok github.com/novox/mesh-controller/internal/conditions 2.649s ok github.com/novox/mesh-controller/internal/envfile 1.024s ok github.com/novox/mesh-controller/internal/facts 1.030s ok github.com/novox/mesh-controller/internal/identity 6.168s ok github.com/novox/mesh-controller/internal/inventory 137.104s ok github.com/novox/mesh-controller/internal/lease 17.630s ok github.com/novox/mesh-controller/internal/licences 5.237s ok github.com/novox/mesh-controller/internal/licences/adapters 1.015s ok github.com/novox/mesh-controller/internal/link 69.381s ok github.com/novox/mesh-controller/internal/lint 2.699s ok github.com/novox/mesh-controller/internal/outward 1.054s ok github.com/novox/mesh-controller/internal/overlay 1.033s ok github.com/novox/mesh-controller/internal/secrets 1.541s ok github.com/novox/mesh-controller/internal/store 3.687s ok github.com/novox/mesh-controller/internal/testbus 1.307s ok github.com/novox/mesh-controller/internal/token 1.025s store tests, each run against the store: ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.47s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.48s) ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.45s) ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.46s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.43s) ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.42s) ./cmd/mesh-controller --- PASS: TestAPlanFollowedFromTheStoreAnswersWhenItMoves (4.96s) ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.55s) ./cmd/mesh-controller --- PASS: TestTheConditionsVerbReadsTheLooksTheBucketNoLongerHolds (0.41s) ./cmd/mesh-controller --- PASS: TestAWalkLetGoAndStoppedByVerbsIsSaidStartedAndEnded (0.63s) ./cmd/mesh-controller --- PASS: TestAWalkStoppedOrClosedByAPersonIsSaidEndedStopped (0.52s) ./cmd/mesh-controller --- PASS: TestAWalkRetriedByAPersonIsSaidStartedAgain (0.48s) ./cmd/mesh-controller --- PASS: TestABacklogReleasedByAPersonIsSaidStarted (0.48s) ./cmd/mesh-controller --- PASS: TestAWalkEndedByCancelOrClearIsSaidEnded (0.54s) ./cmd/mesh-controller --- PASS: TestAWalkRestartedByARebuildIsSaidStarted (0.51s) ./cmd/mesh-controller --- PASS: TestAWalkStoppedByHandAndRetriedEndsFailedWhenItFailsAgain (0.49s) ./cmd/mesh-controller --- PASS: TestReplay237 (1.78s) ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeUnresolvedSaysSoOnceInItsAnswer (0.42s) ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeResolvedSaysNothingOfIt (0.43s) ./cmd/mesh-controller --- PASS: TestAnAssignThatLeavesItsNodeUnresolvedSaysOnlyThePlansRefusal (0.44s) ./cmd/mesh-controller --- PASS: TestADirectoryOwnersKeyIsRefusedThroughAVerb (1.70s) ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.28s) ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.28s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.30s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.29s) ./internal/inventory --- PASS: TestAConditionsLooksAreKeptBesideTheBucket (0.27s) ./internal/inventory --- PASS: TestAWalksStartIsKeptAndARefusedSaveLeavesItUnsaid (0.28s) ```
mesh-admin left a comment
Author
Contributor

Verdict: approve at 5ad36127ee

Re-review against review 75. Merge #268 first, then this.

  • The blocking point is closed by #268. I merged main (3cfc121) + #268 (a1a6f64) + this head (5ad3612) and the merge was clean.
    • On that combined tree, commandLine for plans calls plainPlanIDs, which lists wait.
    • argvFor("plans", {wait: "x' or '1'='1"}) is refused with "plans wait: "x' or '1'='1" is not a plan's id (plan- or release- …); nothing was done".
    • {wait: "plan-<digits>", until: "tier"} still composes.
    • PlanByID binds $1 either way.
    • merge-check.sh on the combined tree, with a throwaway Postgres, exits 0 under -race; both new store tests pass.
  • Minor 1, fixed: TestThePlansSchemaSaysTheLongestBoundThereIs holds the schema's words to maxPlanWait.String().
  • Minor 2, fixed: the planWaitStart comment says that a slow store degrades to "still running", followed up with calls.
  • Ran on this head: targeted go test -race passes.
  • Statuses on the head: mesh/merge-gate, mesh/repo-check and mesh/delivery all read success, and the PR is mergeable.
  • Merge order matters: merged alone before #268, this would still carry the review-75 injection path. Merge it only after #268.
Verdict: approve at 5ad36127ee8bf3a5c3c99dc4821a78a9a98f9b88 Re-review against review 75. Merge #268 first, then this. - **The blocking point is closed by #268.** I merged main (3cfc121) + #268 (a1a6f64) + this head (5ad3612) and the merge was clean. - On that combined tree, `commandLine` for `plans` calls `plainPlanIDs`, which lists `wait`. - `argvFor("plans", {wait: "x' or '1'='1"})` is refused with "plans wait: \"x' or '1'='1\" is not a plan's id (plan-<digits> or release-<digits> …); nothing was done". - `{wait: "plan-<digits>", until: "tier"}` still composes. - `PlanByID` binds `$1` either way. - `merge-check.sh` on the combined tree, with a throwaway Postgres, exits 0 under -race; both new store tests pass. - **Minor 1, fixed:** `TestThePlansSchemaSaysTheLongestBoundThereIs` holds the schema's words to `maxPlanWait.String()`. - **Minor 2, fixed:** the `planWaitStart` comment says that a slow store degrades to "still running", followed up with `calls`. - **Ran on this head:** targeted `go test -race` passes. - **Statuses on the head:** mesh/merge-gate, mesh/repo-check and mesh/delivery all read success, and the PR is mergeable. - **Merge order matters:** merged alone before #268, this would still carry the review-75 injection path. Merge it only after #268.
Author
Contributor

Merge check at 5ad36127
Judged: head 5ad36127ee8b merged into trunk f8daec01d3f0; read beside it: mesh-catalog 23ea0f431faf, mesh-controller-main f8daec01d3f0, mesh-host a1f9856b3957, mesh-tools 954e1a53eef9

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine
  • read by no module's build: cmd/mesh-controller/plans_follow_test.go, internal/link/calls_wait_test.go, testdata/store-tests

Run by the build seat on novox as build-1791823903440516146 (builds --log build-1791823903440516146).

--- the gate: build-agent, mesh-controller
mesh-controller: ok, 58 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T16:48:14Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-12T16:48:14Z

modules the change moves:
  - mesh-controller (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller

notes:
  - cmd/mesh-controller/plans_follow_test.go, internal/link/calls_wait_test.go and testdata/store-tests read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.067s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	331.217s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.018s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.044s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.027s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.131s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.060s
?   	github.com/novox/mesh-controller/internal/beside	[no test files]
ok  	github.com/novox/mesh-controller/internal/broker	5.057s
ok  	github.com/novox/mesh-controller/internal/builder	46.621s
ok  	github.com/novox/mesh-controller/internal/catalogue	9.659s
ok  	github.com/novox/mesh-controller/internal/conditions	2.785s
ok  	github.com/novox/mesh-controller/internal/envfile	1.031s
ok  	github.com/novox/mesh-controller/internal/facts	1.028s
ok  	github.com/novox/mesh-controller/internal/identity	5.810s
ok  	github.com/novox/mesh-controller/internal/inventory	118.844s
ok  	github.com/novox/mesh-controller/internal/lease	17.646s
ok  	github.com/novox/mesh-controller/internal/licences	5.122s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.019s
ok  	github.com/novox/mesh-controller/internal/link	67.039s
ok  	github.com/novox/mesh-controller/internal/lint	2.620s
ok  	github.com/novox/mesh-controller/internal/outward	1.055s
ok  	github.com/novox/mesh-controller/internal/overlay	1.029s
ok  	github.com/novox/mesh-controller/internal/secrets	1.571s
ok  	github.com/novox/mesh-controller/internal/store	3.589s
ok  	github.com/novox/mesh-controller/internal/testbus	1.210s
ok  	github.com/novox/mesh-controller/internal/token	1.033s
store tests, each run against the store:
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.50s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.53s)
  ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.54s)
  ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.58s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.48s)
  ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.46s)
  ./cmd/mesh-controller --- PASS: TestAPlanFollowedFromTheStoreAnswersWhenItMoves (4.57s)
  ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.48s)
  ./cmd/mesh-controller --- PASS: TestTheConditionsVerbReadsTheLooksTheBucketNoLongerHolds (0.33s)
  ./cmd/mesh-controller --- PASS: TestAWalkLetGoAndStoppedByVerbsIsSaidStartedAndEnded (0.56s)
  ./cmd/mesh-controller --- PASS: TestAWalkStoppedOrClosedByAPersonIsSaidEndedStopped (0.52s)
  ./cmd/mesh-controller --- PASS: TestAWalkRetriedByAPersonIsSaidStartedAgain (0.44s)
  ./cmd/mesh-controller --- PASS: TestABacklogReleasedByAPersonIsSaidStarted (0.47s)
  ./cmd/mesh-controller --- PASS: TestAWalkEndedByCancelOrClearIsSaidEnded (0.58s)
  ./cmd/mesh-controller --- PASS: TestAWalkRestartedByARebuildIsSaidStarted (0.53s)
  ./cmd/mesh-controller --- PASS: TestAWalkStoppedByHandAndRetriedEndsFailedWhenItFailsAgain (0.52s)
  ./cmd/mesh-controller --- PASS: TestReplay237 (0.52s)
  ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeUnresolvedSaysSoOnceInItsAnswer (0.43s)
  ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeResolvedSaysNothingOfIt (0.56s)
  ./cmd/mesh-controller --- PASS: TestAnAssignThatLeavesItsNodeUnresolvedSaysOnlyThePlansRefusal (0.62s)
  ./cmd/mesh-controller --- PASS: TestADirectoryOwnersKeyIsRefusedThroughAVerb (0.51s)
  ./cmd/mesh-controller --- PASS: TestTheSendMakesNoValueForAnOutsideSecretNobodyGave (0.85s)
  ./cmd/mesh-controller --- PASS: TestAQuestionComposesWithoutAnOutsideSecretNobodyGave (0.69s)
  ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.59s)
  ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.42s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.38s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.37s)
  ./internal/inventory --- PASS: TestAConditionsLooksAreKeptBesideTheBucket (0.30s)
  ./internal/inventory --- PASS: TestAPlanIdHoldingAQuoteIsReadAsAPlainId (0.37s)
  ./internal/inventory --- PASS: TestAWalksStartIsKeptAndARefusedSaveLeavesItUnsaid (0.59s)
**Merge check** at `5ad36127` Judged: head `5ad36127ee8b` merged into trunk `f8daec01d3f0`; read beside it: mesh-catalog `23ea0f431faf`, mesh-controller-main `f8daec01d3f0`, mesh-host `a1f9856b3957`, mesh-tools `954e1a53eef9` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine - read by no module's build: cmd/mesh-controller/plans_follow_test.go, internal/link/calls_wait_test.go, testdata/store-tests Run by the build seat on novox as `build-1791823903440516146` (`builds --log build-1791823903440516146`). ``` --- the gate: build-agent, mesh-controller mesh-controller: ok, 58 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T16:48:14Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-12T16:48:14Z modules the change moves: - mesh-controller (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller notes: - cmd/mesh-controller/plans_follow_test.go, internal/link/calls_wait_test.go and testdata/store-tests read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.067s ok github.com/novox/mesh-controller/cmd/mesh-controller 331.217s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.018s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.044s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.027s ok github.com/novox/mesh-controller/examples/route-proxy 1.131s ok github.com/novox/mesh-controller/internal/artifacts 1.060s ? github.com/novox/mesh-controller/internal/beside [no test files] ok github.com/novox/mesh-controller/internal/broker 5.057s ok github.com/novox/mesh-controller/internal/builder 46.621s ok github.com/novox/mesh-controller/internal/catalogue 9.659s ok github.com/novox/mesh-controller/internal/conditions 2.785s ok github.com/novox/mesh-controller/internal/envfile 1.031s ok github.com/novox/mesh-controller/internal/facts 1.028s ok github.com/novox/mesh-controller/internal/identity 5.810s ok github.com/novox/mesh-controller/internal/inventory 118.844s ok github.com/novox/mesh-controller/internal/lease 17.646s ok github.com/novox/mesh-controller/internal/licences 5.122s ok github.com/novox/mesh-controller/internal/licences/adapters 1.019s ok github.com/novox/mesh-controller/internal/link 67.039s ok github.com/novox/mesh-controller/internal/lint 2.620s ok github.com/novox/mesh-controller/internal/outward 1.055s ok github.com/novox/mesh-controller/internal/overlay 1.029s ok github.com/novox/mesh-controller/internal/secrets 1.571s ok github.com/novox/mesh-controller/internal/store 3.589s ok github.com/novox/mesh-controller/internal/testbus 1.210s ok github.com/novox/mesh-controller/internal/token 1.033s store tests, each run against the store: ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.50s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.53s) ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.54s) ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.58s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.48s) ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.46s) ./cmd/mesh-controller --- PASS: TestAPlanFollowedFromTheStoreAnswersWhenItMoves (4.57s) ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.48s) ./cmd/mesh-controller --- PASS: TestTheConditionsVerbReadsTheLooksTheBucketNoLongerHolds (0.33s) ./cmd/mesh-controller --- PASS: TestAWalkLetGoAndStoppedByVerbsIsSaidStartedAndEnded (0.56s) ./cmd/mesh-controller --- PASS: TestAWalkStoppedOrClosedByAPersonIsSaidEndedStopped (0.52s) ./cmd/mesh-controller --- PASS: TestAWalkRetriedByAPersonIsSaidStartedAgain (0.44s) ./cmd/mesh-controller --- PASS: TestABacklogReleasedByAPersonIsSaidStarted (0.47s) ./cmd/mesh-controller --- PASS: TestAWalkEndedByCancelOrClearIsSaidEnded (0.58s) ./cmd/mesh-controller --- PASS: TestAWalkRestartedByARebuildIsSaidStarted (0.53s) ./cmd/mesh-controller --- PASS: TestAWalkStoppedByHandAndRetriedEndsFailedWhenItFailsAgain (0.52s) ./cmd/mesh-controller --- PASS: TestReplay237 (0.52s) ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeUnresolvedSaysSoOnceInItsAnswer (0.43s) ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeResolvedSaysNothingOfIt (0.56s) ./cmd/mesh-controller --- PASS: TestAnAssignThatLeavesItsNodeUnresolvedSaysOnlyThePlansRefusal (0.62s) ./cmd/mesh-controller --- PASS: TestADirectoryOwnersKeyIsRefusedThroughAVerb (0.51s) ./cmd/mesh-controller --- PASS: TestTheSendMakesNoValueForAnOutsideSecretNobodyGave (0.85s) ./cmd/mesh-controller --- PASS: TestAQuestionComposesWithoutAnOutsideSecretNobodyGave (0.69s) ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.59s) ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.42s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.38s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.37s) ./internal/inventory --- PASS: TestAConditionsLooksAreKeptBesideTheBucket (0.30s) ./internal/inventory --- PASS: TestAPlanIdHoldingAQuoteIsReadAsAPlainId (0.37s) ./internal/inventory --- PASS: TestAWalksStartIsKeptAndARefusedSaveLeavesItUnsaid (0.59s) ```
mesh-admin merged commit ba685b17f5 into main 2026-10-12 17:06:51 +00:00
mesh-admin deleted branch fix/229-plans-wait 2026-10-12 17:06:51 +00:00
This repo is archived. You cannot comment on pull requests.
No Reviewers
2 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-controller#266