mesh-delivery-indexer: the judge's tests ask nothing of the composition's offers, overflow or left-out reasons
ADR 0593 §7: OffersIssuedOutside, Resolution and UnknownFieldReason left mesh-sdk with the composition, so the judge's tests keep its own reading and refusals and those proofs go to the node-engine's tests. Claude-Session: https://claude.ai/code/session_01NcbgfJ9Gum47zkFKWRaovL
This commit is contained in:
@@ -1870,9 +1870,6 @@ func TestAnOfferMaySayAPersonOutsideTheMeshIssuesItsCredential(t *testing.T) {
|
||||
if _, shared := m.SharedCredentialOf("tv-api"); shared {
|
||||
t.Fatal("a credential issued outside was read as an own secret shared")
|
||||
}
|
||||
if who, offered := catalogue.OffersIssuedOutside(map[string]catalogue.Manifest{"tv": m}, "tv-api"); !offered || who != "tv" {
|
||||
t.Fatalf("the catalogue does not say tv offers tv-api issued outside: %q %v", who, offered)
|
||||
}
|
||||
|
||||
for want, raw := range map[string]string{
|
||||
"names its own secret": `{"module":"d","version":"1","own-secrets":{"key":{"path":"/p","taken":"at-start"}},
|
||||
@@ -2612,12 +2609,7 @@ func TestARequirementOnAKeylessProvisionComposesWithALongName(t *testing.T) {
|
||||
if got := IdentityProblems(shelf, 6); len(got) != 0 {
|
||||
t.Fatalf("a requirement on a keyless provision was refused for its length: %q", got)
|
||||
}
|
||||
r := catalogue.Resolution{Node: "laptop", Modules: []catalogue.Manifest{shelf["networkmanager"]},
|
||||
Needs: []catalogue.Needed{{Name: "wildcard-resolution", From: "anchor", For: "networkmanager",
|
||||
Identity: shelf["resolver"].IdentityBoundOf("wildcard-resolution")}}}
|
||||
if got := r.Overflowing(); len(got) != 0 {
|
||||
t.Fatalf("a keyless requirement is reported as overflowing: %+v", got)
|
||||
}
|
||||
// Whether the composed requirement overflows on the machine is the node-engine's composition to say (ADR 0593 §7).
|
||||
}
|
||||
|
||||
// A resolved manifest keeps a built artifact's reference in the store-relative form, never the
|
||||
@@ -5739,9 +5731,6 @@ func aModuleWithAFieldSetAsideStillProvidesWhatItProvides(t *testing.T) {
|
||||
t.Errorf("unknown %q does not say it read without %s", m.UnknownField(), want)
|
||||
}
|
||||
}
|
||||
if why := catalogue.UnknownFieldReason(m); why != "" {
|
||||
t.Fatal(why)
|
||||
}
|
||||
}
|
||||
|
||||
func notifier() catalogue.Manifest {
|
||||
|
||||
Reference in New Issue
Block a user