Name the view's tools binary as what its bundle loads, as the controller's module check requires of a bundle compiled to a binary (issue 1562)
mesh/merge-gate head 1239199b35dd merged into trunk d68d7ef3d9af — pass: builds mesh-delivery-view → shanks; no bus step; every machine composes with the c…
mesh/repo-check head 1239199b35dd merged into trunk d68d7ef3d9af — pass: its merge-check.sh passed
mesh/delivery delivered
mesh/merge-gate head 1239199b35dd merged into trunk d68d7ef3d9af — pass: builds mesh-delivery-view → shanks; no bus step; every machine composes with the c…
mesh/repo-check head 1239199b35dd merged into trunk d68d7ef3d9af — pass: its merge-check.sh passed
mesh/delivery delivered
This commit is contained in:
@@ -99,8 +99,10 @@ func TestManifestIsTakenAndReadsOnly(t *testing.T) { // 1134/AC7
|
||||
t.Errorf("tools = %v, want %v", m.Tools, want)
|
||||
}
|
||||
for _, a := range m.Build.Artifacts {
|
||||
if a.Name == "tools" && !reflect.DeepEqual(a.Loads, []string{"mesh-delivery-view"}) {
|
||||
t.Errorf("the tools artifact loads %v, want the view", a.Loads)
|
||||
// A bundle compiled to a binary is one executable: what the runtime loads is that binary's name, or the controller's
|
||||
// module check refuses the manifest (mesh-sdk catalogue build.go, ADR 0193).
|
||||
if a.Name == "tools" && !reflect.DeepEqual(a.Loads, []string{a.Binary}) {
|
||||
t.Errorf("the tools artifact loads %v, want its binary %q", a.Loads, a.Binary)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -109,7 +109,7 @@
|
||||
"from": "cmd/mesh-delivery-view-tools",
|
||||
"binary": "mesh-delivery-view-tools",
|
||||
"loads": [
|
||||
"mesh-delivery-view"
|
||||
"mesh-delivery-view-tools"
|
||||
]
|
||||
},
|
||||
{
|
||||
|
||||
Reference in New Issue
Block a user