Design 47 H1: validate reads the base the take-in names on the catalog revision; the indexer's restart tests wait for the bus (H-A-151, H-A-154, H §743)
#274
Merged
mesh-toolsmerged 3 commits from fix/47-H1-indexer-toolchains-test into main2026-11-20 16:09:51 +00:00
Every revision the validate test judged with a base had it at its number minus one, so the test
passed with the case before read as the number before (review round 1). Revision 12 now names base
7 with 8 to 11 never kept: it ends manifest-refused against base 7's manifests, and could not run
when the case before is read as the number minus one. No test added.
Builds: design 47 H-A-154 (hq design/47-H1-answers-59 01842bbe), H-A-151
A take-in that moves nothing keeps no revision for its source number, so validate's case before,
read as the step's revision minus one, named a revision never kept and could not run. The take-in
now writes, on the catalog revision it keeps, the field base: the newest kept revision below it,
the one it pins for its pipeline, in the same write; absent on the branch's first take-in. The
assigner's validate reads the base from the revision it already asks for; where the revision names
none the case before is empty and its end says so, never a could-not-run.
- mesh-delivery-contracts: the seat mesh-catalog's CatalogRevision gains base (schema, fixture,
generated Go and TypeScript by seatgen).
- mesh-delivery-indexer: keepBranchEntries names the base it pins; the pin test's rows check it.
- mesh-delivery-assigner: before reads the base; the validate test asks a revision with none, and
both stand-ins name the base as the take-in does.
Builds: design 47 H-A-151, H-A-154 (hq design/47-H1-answers-59 01842bbe), H-A-147, H-A-108 (3), design 47 H §743
TestIndexerCountsOnlyThePlacedBuildNodesToolchains failed on the build node under load
(pipeline main.18) in two ways, both of the test, not of the indexer's count of the
placed build nodes' toolchains:
- it restarted the indexer as soon as the module was written, before its take-in
ended: the stop cancelled the take-in, its source-moved stayed unacknowledged, and
the branch's durable (one message at a time) held the next one behind it for its
acknowledgement wait, past the test's 20 s bound. Each restart now waits for the
source-moved's acknowledgement; TestIndexerWhole's restart the same way.
- a source-moved said right after a restart could reach the stopped program's pull,
still counted until the bus closed its connection. restart now returns only once
the bus has closed every connection of the stopped program, heard on the system
account's disconnect events, with no sleep.
Under load (8 runs side by side, GOMAXPROCS=1) the test failed 5 of 80 runs before,
2 of 240 with the first change alone, and 0 of 600 with both; TestIndexerWhole 0 of 600.
No test added.
Builds: design 47 H §743