A settings proposal shows its values whole where the sender is proven, and its message is the change alone (issue 383) #202
Closed
mesh-admin
wants to merge 3 commits from
fix/383-a-proposal-reads-whole-on-the-phone into main
pull from: fix/383-a-proposal-reads-whole-on-the-phone
merge into: :main
:main
:fix/sweep-2026-10-30
:fix/checker-full-failure
:feat/1945-user-list-switch
:fix/1945-mesh-grants-publishes-memberships
:fix/issued-states-follow-the-module
:fix/1945-credential-on-assignment
:fix/r6-mirror-on-change
:fix/store-forge-address
:fix/r6-look-again-after-unlock
:fix/r6-key-waits-said
:fix/1931-reconnects-verb
:fix/forge-requires-no-status
:fix/906-lease-renewal
:feat/r4e-controller
:fix/1106-sdk-member-merges
:fix/1399-person-word-test
:fix/1652-checks-wait
:feat/files-through-the-store-files-verbs
:fix/1649-held-ask-handed-out-twice
:fix/1658-sdk-items
:fix/1334-a-bus-reload-fails-a-tier
:feat/chain-on-the-bus
:fix/701-a-name-nothing-answers-is-not-used
:fix/270-a-dead-bus-watch-is-heard
:fix/630-config-values-from-four-sources
:fix/613-node-smb-server
:feat/328-libraries-and-module-users
:feat/325-identities-and-kept-folders
:feat/bus-view-principal
:test/plan-diff-left-out-line
:fix/the-registry-trust-test-reads-the-runtimes-module
:fix/the-runtime-file-is-the-runtimes
:feat/build-edges-are-recorded
:fix/several-contributions-collide-in-grants-v2
No Reviewers
No labels
Milestone
No items
No Milestone
Assignees
agent-ace
agent-g14
agent-novox
agent-shanks
jschoubben
mesh-tools
miel.truyen
nox-agent
Clear assignees
No Assignees
No due date set.
Dependencies
No dependencies set.
Reference: novox/mesh-controller#202
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes issue 383 (a settings proposal reads as one wall of text on the phone; "+ shares: media=‹path›" left the operator approving blind).
The ask carries the change twice: the explanation under the content rule, as before (the desk, and conditions, are unchanged), and the whole (
asks.Ask.Whole), which the router shows only on a channel that proves who answers; only a value shaped like a secret is withheld there (outward.Secret, and the proposal is refused at once if one were left). The message is the headline, one line per key, who proposed it and when; the fingerprint and how to read the proposal whole are the Details answer's (asks.Ask.Details). The warrant binds as before: the option's act digest covers the exact values, and the ask's digest now covers the whole and the Details too.Vendors mesh-sdk go at
v0.1.13-0.20261010132341-4f3efc98e0c0(branchfix/383-an-ask-says-what-a-proving-channel-shows-whole, commit 4f3efc9).Merge order: mesh-sdk, then mesh-catalog (the router must know the new fields before a controller sends an ask with them, or the digests differ and the warrant is refused — loudly, nothing is set), then this.
Delivery
novox/mesh-controller@95b93626d20e— stopped since 2026-10-13T14:39:55ZDelivery plan — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step
Group
fix/383-a-proposal-reads-whole-on-the-phone, in order: novox/mesh-controller@95b93626d2 → novox/mesh-catalog@69040849a3Transitions
The commit's note under
refs/notes/mesh-plankeeps every transition:git log --notes=mesh-plan.The review of 2026-10-10: a mixed-case path with a digit ("/mnt/Photos_2024/Jochen") read as a random string and was withheld from the whole words, the symptom again (outward.Secret now judges a run with a slash piece by piece, as the messenger's CheckSecret does); and the Details line on masking read, on the phone, as if something there were masked.Merge check at
7a922248mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller, route-proxy)mesh/repo-check: PASS — its merge-check.sh passedDelivery plan — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step
Run by the build seat on novox as
build-1791639553991852388(builds --log build-1791639553991852388).Merge check at
68557b41mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller, route-proxy)mesh/repo-check: PASS — its merge-check.sh passedDelivery plan — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step
Run by the build seat on g14 as
build-1791640040215899601(builds --log build-1791640040215899601).Merge check at
95b93626mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller, route-proxy)mesh/repo-check: PASS — its merge-check.sh passedDelivery plan — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step
Run by the build seat on shanks as
build-1791640559863897010(builds --log build-1791640559863897010).Replaced by #304, which rebases this work on main (the SDK is now vendored at mesh-sdk #25's head) and reshapes the ask for issue 639: a summary line, at most three key points, the fingerprint and how-to in the Details. The whole/masked change is carried over. Closing this one.