A provider waiting for the operator holds its consumers, and a wait beside another condition is said (issue 405) #216

Merged
mesh-admin merged 4 commits from fix/405-a-waiting-provider-holds-its-consumers into main 2026-10-11 01:23:35 +00:00
Contributor

Fixes novox/hq issue 405, which came out of the review of the ADR 0283 change (issue 386). Part 1 builds a design limit that ADR 0283 and ADR 0240 rule 5 did not settle, so it is recorded as a new decision: ADR 0292, "A consumer of the part a provider waits on is held under the wait, and passes its gate as a wait for a person" (novox/hq#309). Parts 2 and 3 follow from ADR 0283 as written.

1. A provider that waits for the operator holds the consumers of its waiting part (ADR 0292)

  • What is held (ADR 0292 rules 1 and 2). holding.providerState now reads a provider in one of three ways: unhealthy, waiting for the operator, or healthy. A waiting provider holds a consumer's finding only when one of its waits covers the provision that finding needs. A wait covers a provision when its part is that provision's name, or when the secret it waits for is the provision's shared credential (credential.own, ADR 0158). This follows ADR 0283 decision 1: a module that says it waits is saying nothing else is wrong with it, and each wait names its part.
  • What is not held (ADR 0292 rule 3). A consumer of another part raises its own unhealthy condition. So does a consumer whose provision cannot be matched to a wait, for example when only the provider's needs-operator condition is open and no statement lists its waits. That condition's evidence says "

    on waits for you, but not for anything is known to need, so 's fault is said on its own."

  • The gate (ADR 0292 rule 4; ADR 0283 decision 4; ADR 0254). A consumer whose held findings all wait on a provider that only waits for the operator gets the reading waits for a person. That reading is a pass, and the verdict carries the wait: "its container shop.web on laptop waits on db on anchor, which waits for you: <the provider's wait and its nox secret ask line>". Under an unhealthy provider, the consumer's gate waits as before ("… which is unhealthy").
  • The severity (ADR 0292 rule 5; ADR 0283 decision 5). The provider's needs-operator condition lists who waits on it but stays a warning. unhealthy and relogin-needed are still urgent while consumers wait, as before.
  • When a consumer's statement arrives first. sayWaiters also says the provider's needs-operator condition again, from the consumer's own judging.
  • When a consumer becomes held. Its own condition clears with a line that says which state the provider is in: "… waits on db on anchor, which waits for you: held under its condition" or "…, which is unhealthy: …".

2. A wait beside another condition is said (ADR 0283 decision 5)

A module with a checked wait beside a relogin, a directory used as found, or a fault of its own used to be said only as that other condition. Now it also raises module.<m>.<machine>.needs-operator for the wait, after the same two statements. The other condition is judged on the rest of the module, so a fault's words no longer count the waiting part as failing.

3. secretsReadBy covers family members (ADR 0283 decision 6)

A container or daemon that names the path of a member that was given is restarted on that member's needs-<member>.

Tests

All tests are in cmd/mesh-controller/waiting_provider_test.go, plus TestAContainerReadingAFamilyMemberIsRestartedWhenItChanges. None needs a store: readHoldingFor is a test seam, and heldReadings is split out of gatherGateFacts.

I broke each change on purpose and ran the tests to show which one fails:

Change broken Test that fails
the gate's person reading TestAConsumersGateUnderAWaitingProviderPassesCarryingTheWait
holding only the waiting part …HoldsOnlyTheConsumersOfTheWaitingPart, TestAConsumerOfAnotherPartIsRaisedOnItsOwn
the shared-credential match …HoldsOnlyTheConsumersOfTheWaitingPart
no new urgency …ListsWhoWaitsOnItAndStaysAWarning
sayWaiters returning nil …ListsWhoWaitsOnItAndStaysAWarning (runs without a store)
the unmatched consumer's words TestAConsumerOfAnotherPartIsRaisedOnItsOwn
the clearing line's state TestAConsumerHeldOnceItsProviderWaitsSaysWhichItIs

The tests for part 2 and part 3 failed on main.

Run: go vet ./... is clean, and go test ./cmd/mesh-controller/ passes. In ./internal/catalogue/, only TestTheServiceManagerReadsTheSystemdRenderingAsMeant fails, which is issue 432 and unrelated. Store-backed tests skip without MESH_TEST_POSTGRES. This change touches no file of #213, #214, #215 or the 432 fix.

What the operator sees

  • A provider waiting for a secret or setting: one needs-operator warning at the provider. It names what the operator has to do and lists the consumers of the waiting part, and it never becomes urgent.
  • Consumers of the waiting part: they raise nothing of their own. Their first-node gates pass and carry the wait, so a walk is never held for the operator's secret.
  • Consumers of another part, or of a part that cannot be matched: they keep their own unhealthy condition, which says that their provider waits for you but not for anything they are known to need.
  • A module that waits and also needs a new login, has a directory used as found, or has a fault: it shows needs-operator beside that other condition.

No provider names a part after a provision today, so the hold in part 1 does nothing until one does (ADR 0292, consequences).

Fixes novox/hq issue 405, which came out of the review of the ADR 0283 change (issue 386). Part 1 builds a design limit that ADR 0283 and ADR 0240 rule 5 did not settle, so it is recorded as a new decision: **ADR 0292**, "A consumer of the part a provider waits on is held under the wait, and passes its gate as a wait for a person" (novox/hq#309). Parts 2 and 3 follow from ADR 0283 as written. ## 1. A provider that waits for the operator holds the consumers of its waiting part (ADR 0292) - **What is held** (ADR 0292 rules 1 and 2). `holding.providerState` now reads a provider in one of three ways: unhealthy, waiting for the operator, or healthy. A waiting provider holds a consumer's finding only when one of its waits covers the provision that finding needs. A wait covers a provision when its `part` is that provision's name, or when the secret it waits for is the provision's shared credential (`credential.own`, ADR 0158). This follows ADR 0283 decision 1: a module that says it waits is saying nothing else is wrong with it, and each wait names its part. - **What is not held** (ADR 0292 rule 3). A consumer of another part raises its own `unhealthy` condition. So does a consumer whose provision cannot be matched to a wait, for example when only the provider's `needs-operator` condition is open and no statement lists its waits. That condition's evidence says "<p> on <node> waits for you, but not for anything <consumer> is known to need, so <consumer>'s fault is said on its own." - **The gate** (ADR 0292 rule 4; ADR 0283 decision 4; ADR 0254). A consumer whose held findings all wait on a provider that only waits for the operator gets the reading *waits for a person*. That reading is a pass, and the verdict carries the wait: "its container shop.web on laptop waits on db on anchor, which waits for you: <the provider's wait and its `nox secret ask` line>". Under an unhealthy provider, the consumer's gate waits as before ("… which is unhealthy"). - **The severity** (ADR 0292 rule 5; ADR 0283 decision 5). The provider's `needs-operator` condition lists who waits on it but stays a warning. `unhealthy` and `relogin-needed` are still urgent while consumers wait, as before. - **When a consumer's statement arrives first.** `sayWaiters` also says the provider's `needs-operator` condition again, from the consumer's own judging. - **When a consumer becomes held.** Its own condition clears with a line that says which state the provider is in: "… waits on db on anchor, which waits for you: held under its condition" or "…, which is unhealthy: …". ## 2. A wait beside another condition is said (ADR 0283 decision 5) A module with a checked wait beside a relogin, a directory used as found, or a fault of its own used to be said only as that other condition. Now it also raises `module.<m>.<machine>.needs-operator` for the wait, after the same two statements. The other condition is judged on the rest of the module, so a fault's words no longer count the waiting part as failing. ## 3. `secretsReadBy` covers family members (ADR 0283 decision 6) A container or daemon that names the path of a member that was given is restarted on that member's `needs-<member>`. ## Tests All tests are in `cmd/mesh-controller/waiting_provider_test.go`, plus `TestAContainerReadingAFamilyMemberIsRestartedWhenItChanges`. None needs a store: `readHoldingFor` is a test seam, and `heldReadings` is split out of `gatherGateFacts`. I broke each change on purpose and ran the tests to show which one fails: | Change broken | Test that fails | |---|---| | the gate's person reading | `TestAConsumersGateUnderAWaitingProviderPassesCarryingTheWait` | | holding only the waiting part | `…HoldsOnlyTheConsumersOfTheWaitingPart`, `TestAConsumerOfAnotherPartIsRaisedOnItsOwn` | | the shared-credential match | `…HoldsOnlyTheConsumersOfTheWaitingPart` | | no new urgency | `…ListsWhoWaitsOnItAndStaysAWarning` | | `sayWaiters` returning nil | `…ListsWhoWaitsOnItAndStaysAWarning` (runs without a store) | | the unmatched consumer's words | `TestAConsumerOfAnotherPartIsRaisedOnItsOwn` | | the clearing line's state | `TestAConsumerHeldOnceItsProviderWaitsSaysWhichItIs` | The tests for part 2 and part 3 failed on main. **Run:** `go vet ./...` is clean, and `go test ./cmd/mesh-controller/` passes. In `./internal/catalogue/`, only `TestTheServiceManagerReadsTheSystemdRenderingAsMeant` fails, which is issue 432 and unrelated. Store-backed tests skip without `MESH_TEST_POSTGRES`. This change touches no file of #213, #214, #215 or the 432 fix. ## What the operator sees - **A provider waiting for a secret or setting:** one `needs-operator` warning at the provider. It names what the operator has to do and lists the consumers of the waiting part, and it never becomes urgent. - **Consumers of the waiting part:** they raise nothing of their own. Their first-node gates pass and carry the wait, so a walk is never held for the operator's secret. - **Consumers of another part, or of a part that cannot be matched:** they keep their own `unhealthy` condition, which says that their provider waits for you but not for anything they are known to need. - **A module that waits and also needs a new login, has a directory used as found, or has a fault:** it shows `needs-operator` beside that other condition. No provider names a part after a provision today, so the hold in part 1 does nothing until one does (ADR 0292, consequences).
mesh-admin added 2 commits 2026-10-11 00:51:27 +00:00
A provider whose only part not healthy waits for the operator's secret or
setting let its consumers raise their own unhealthy conditions, and a
wait beside a relogin, a directory used as found or a fault was not said
until the other cleared.
Restart what reads a secret family member when the member is given again (issue 405)
mesh/merge-gate pass: builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step; every machine composes with the change as it did without …
mesh/repo-check fail: its merge-check.sh failed: --- FAIL: TestTheSecondControllerWaitsAndTakesAHigherEpochOnHandover (4.67s)
mesh/delivery superseded: a newer head of the same pull request
d6b867a87a
secretsReadBy looked only at secrets declared by name, so a container
mounting a member kept the value it started with.
Author
Contributor

Delivery novox/mesh-controller@d5cf3b42fec6 — failed since 2026-10-11T01:30:33Z

Covered: covered after its failure: a later walk that contains it was delivered: plan-1791681844507629611 (novox/mesh-controller at 7493bd8f into main, done, contains its merge 7493bd8f)

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves

Machines

  • mesh-controller on novox: passed — healthy 3 times over 3m36s
  • mesh-controller on the rest running it: sent
  • build-agent on ace: passed — healthy 3 times over 3m24s
  • build-agent on the rest running it: sent

Transitions

  • 2026-10-11 01:05 (new) → proposed (announced): novox/mesh-controller#216's head announced
  • 2026-10-11 01:12 proposed → checked (checked): the verdict names this commit
  • 2026-10-11 01:12 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-11 01:25 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-11 01:25 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
  • 2026-10-11 01:30 delivering → failed (failed): its walk failed, carrying its own commit: a gate on a first machine (what it carried put back), a build, a machine

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-controller@d5cf3b42fec6` — **failed** since 2026-10-11T01:30:33Z **Covered**: covered after its failure: a later walk that contains it was delivered: plan-1791681844507629611 (novox/mesh-controller at 7493bd8f into main, done, contains its merge 7493bd8f) **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves **Machines** - mesh-controller on novox: passed — healthy 3 times over 3m36s - mesh-controller on the rest running it: sent - build-agent on ace: passed — healthy 3 times over 3m24s - build-agent on the rest running it: sent **Transitions** - 2026-10-11 01:05 (new) → proposed (announced): novox/mesh-controller#216's head announced - 2026-10-11 01:12 proposed → checked (checked): the verdict names this commit - 2026-10-11 01:12 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-11 01:25 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-11 01:25 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit - 2026-10-11 01:30 delivering → failed (failed): its walk failed, carrying its own commit: a gate on a first machine (what it carried put back), a build, a machine The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
Author
Contributor

Merge check at d6b867a8

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller)
  • mesh/repo-check: FAIL — its merge-check.sh failed: --- FAIL: TestTheSecondControllerWaitsAndTakesAHigherEpochOnHandover (4.67s)

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • read by no module's build: cmd/mesh-controller/waiting_provider_test.go, internal/catalogue/secret_restart_test.go

Run by the build seat on novox as build-1791679896903888623 (builds --log build-1791679896903888623).

--- the gate: build-agent, mesh-controller
mesh-controller: ok, 56 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-11T00:44:35Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-11T00:44:35Z

modules the change moves:
  - mesh-controller (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller

notes:
  - cmd/mesh-controller/waiting_provider_test.go and internal/catalogue/secret_restart_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.056s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	278.807s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.019s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.031s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.023s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.136s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.065s
ok  	github.com/novox/mesh-controller/internal/broker	6.812s
ok  	github.com/novox/mesh-controller/internal/builder	8.835s
ok  	github.com/novox/mesh-controller/internal/catalogue	7.301s
ok  	github.com/novox/mesh-controller/internal/conditions	2.587s
ok  	github.com/novox/mesh-controller/internal/envfile	1.024s
ok  	github.com/novox/mesh-controller/internal/facts	1.032s
ok  	github.com/novox/mesh-controller/internal/identity	11.758s
ok  	github.com/novox/mesh-controller/internal/inventory	110.868s
--- FAIL: TestTheSecondControllerWaitsAndTakesAHigherEpochOnHandover (4.67s)
    lease_test.go:71: a: took the controller lease at epoch 1 (a)
    lease_test.go:71: b: another controller holds the lease (a, epoch 1, taken 2026-10-11T00:54:28Z); waiting until it lets go or stops renewing
    lease_test.go:71: a: LOST the controller lease (epoch 1): the renewal could not be made: context deadline exceeded — this controller stops acting at once
    lease_test.go:118: a, holding, answers 0, this controller does not hold the lease: it lost it — the renewal could not be made: context deadline exceeded
    lease_test.go:86: taking: context canceled
FAIL
FAIL	github.com/novox/mesh-controller/internal/lease	17.161s
ok  	github.com/novox/mesh-controller/internal/licences	11.162s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.009s
ok  	github.com/novox/mesh-controller/internal/link	57.969s
ok  	github.com/novox/mesh-controller/internal/lint	2.284s
ok  	github.com/novox/mesh-controller/internal/outward	1.032s
ok  	github.com/novox/mesh-controller/internal/overlay	1.027s
ok  	github.com/novox/mesh-controller/internal/secrets	1.456s
ok  	github.com/novox/mesh-controller/internal/store	7.083s
ok  	github.com/novox/mesh-controller/internal/testbus	1.190s
ok  	github.com/novox/mesh-controller/internal/token	1.018s
FAIL
**Merge check** at `d6b867a8` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller) - `mesh/repo-check`: **FAIL** — its merge-check.sh failed: --- FAIL: TestTheSecondControllerWaitsAndTakesAHigherEpochOnHandover (4.67s) **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - read by no module's build: cmd/mesh-controller/waiting_provider_test.go, internal/catalogue/secret_restart_test.go Run by the build seat on novox as `build-1791679896903888623` (`builds --log build-1791679896903888623`). ``` --- the gate: build-agent, mesh-controller mesh-controller: ok, 56 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-11T00:44:35Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-11T00:44:35Z modules the change moves: - mesh-controller (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller notes: - cmd/mesh-controller/waiting_provider_test.go and internal/catalogue/secret_restart_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.056s ok github.com/novox/mesh-controller/cmd/mesh-controller 278.807s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.019s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.031s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.023s ok github.com/novox/mesh-controller/examples/route-proxy 1.136s ok github.com/novox/mesh-controller/internal/artifacts 1.065s ok github.com/novox/mesh-controller/internal/broker 6.812s ok github.com/novox/mesh-controller/internal/builder 8.835s ok github.com/novox/mesh-controller/internal/catalogue 7.301s ok github.com/novox/mesh-controller/internal/conditions 2.587s ok github.com/novox/mesh-controller/internal/envfile 1.024s ok github.com/novox/mesh-controller/internal/facts 1.032s ok github.com/novox/mesh-controller/internal/identity 11.758s ok github.com/novox/mesh-controller/internal/inventory 110.868s --- FAIL: TestTheSecondControllerWaitsAndTakesAHigherEpochOnHandover (4.67s) lease_test.go:71: a: took the controller lease at epoch 1 (a) lease_test.go:71: b: another controller holds the lease (a, epoch 1, taken 2026-10-11T00:54:28Z); waiting until it lets go or stops renewing lease_test.go:71: a: LOST the controller lease (epoch 1): the renewal could not be made: context deadline exceeded — this controller stops acting at once lease_test.go:118: a, holding, answers 0, this controller does not hold the lease: it lost it — the renewal could not be made: context deadline exceeded lease_test.go:86: taking: context canceled FAIL FAIL github.com/novox/mesh-controller/internal/lease 17.161s ok github.com/novox/mesh-controller/internal/licences 11.162s ok github.com/novox/mesh-controller/internal/licences/adapters 1.009s ok github.com/novox/mesh-controller/internal/link 57.969s ok github.com/novox/mesh-controller/internal/lint 2.284s ok github.com/novox/mesh-controller/internal/outward 1.032s ok github.com/novox/mesh-controller/internal/overlay 1.027s ok github.com/novox/mesh-controller/internal/secrets 1.456s ok github.com/novox/mesh-controller/internal/store 7.083s ok github.com/novox/mesh-controller/internal/testbus 1.190s ok github.com/novox/mesh-controller/internal/token 1.018s FAIL ```
jschoubben added 1 commit 2026-10-11 01:00:31 +00:00
Keep a waiting provider's hold within ADR 0283 (issue 405 review)
mesh/delivery superseded: a newer head of the same pull request
mesh/merge-gate pass: builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step; every machine composes with the change as it did without …
mesh/repo-check pass: its merge-check.sh passed
9a37c143e4
A consumer held under a provider that only waits for the operator now
passes its gate as a wait for a person, carrying the wait, so no walk
waits on the operator's secret. Only consumers of the waiting part are
held; one that cannot be matched is raised on its own and says its
provider waits. needs-operator stays a warning while consumers wait.
jschoubben added 1 commit 2026-10-11 01:05:37 +00:00
Say a waiting provider in the operator's words, and which state it is when a consumer is held (issue 405 review)
mesh/merge-gate pass: builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step; every machine composes with the change as it did without …
mesh/repo-check pass: its merge-check.sh passed
mesh/delivery covered after its failure: a later walk that contains it was delivered: plan-1791681844507629611 (novox/mesh-controller at 7493bd8f into ma…
d5cf3b42fe
Author
Contributor

Merge check at 9a37c143

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • read by no module's build: cmd/mesh-controller/waiting_provider_test.go, internal/catalogue/secret_restart_test.go

Run by the build seat on shanks as build-1791680458221758431 (builds --log build-1791680458221758431).

--- the gate: build-agent, mesh-controller
mesh-controller: ok, 56 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-11T01:00:25Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-11T01:00:25Z

modules the change moves:
  - mesh-controller (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller

notes:
  - cmd/mesh-controller/waiting_provider_test.go and internal/catalogue/secret_restart_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.039s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	243.097s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.034s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.045s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.032s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.246s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.109s
ok  	github.com/novox/mesh-controller/internal/broker	2.871s
ok  	github.com/novox/mesh-controller/internal/builder	2.829s
ok  	github.com/novox/mesh-controller/internal/catalogue	7.466s
ok  	github.com/novox/mesh-controller/internal/conditions	2.588s
ok  	github.com/novox/mesh-controller/internal/envfile	1.059s
ok  	github.com/novox/mesh-controller/internal/facts	1.070s
ok  	github.com/novox/mesh-controller/internal/identity	4.918s
ok  	github.com/novox/mesh-controller/internal/inventory	95.124s
ok  	github.com/novox/mesh-controller/internal/lease	17.730s
ok  	github.com/novox/mesh-controller/internal/licences	4.457s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.045s
ok  	github.com/novox/mesh-controller/internal/link	55.104s
ok  	github.com/novox/mesh-controller/internal/lint	2.365s
ok  	github.com/novox/mesh-controller/internal/outward	1.083s
ok  	github.com/novox/mesh-controller/internal/overlay	1.078s
ok  	github.com/novox/mesh-controller/internal/secrets	1.538s
ok  	github.com/novox/mesh-controller/internal/store	3.541s
ok  	github.com/novox/mesh-controller/internal/testbus	1.227s
ok  	github.com/novox/mesh-controller/internal/token	1.016s
**Merge check** at `9a37c143` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - read by no module's build: cmd/mesh-controller/waiting_provider_test.go, internal/catalogue/secret_restart_test.go Run by the build seat on shanks as `build-1791680458221758431` (`builds --log build-1791680458221758431`). ``` --- the gate: build-agent, mesh-controller mesh-controller: ok, 56 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-11T01:00:25Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-11T01:00:25Z modules the change moves: - mesh-controller (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller notes: - cmd/mesh-controller/waiting_provider_test.go and internal/catalogue/secret_restart_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.039s ok github.com/novox/mesh-controller/cmd/mesh-controller 243.097s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.034s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.045s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.032s ok github.com/novox/mesh-controller/examples/route-proxy 1.246s ok github.com/novox/mesh-controller/internal/artifacts 1.109s ok github.com/novox/mesh-controller/internal/broker 2.871s ok github.com/novox/mesh-controller/internal/builder 2.829s ok github.com/novox/mesh-controller/internal/catalogue 7.466s ok github.com/novox/mesh-controller/internal/conditions 2.588s ok github.com/novox/mesh-controller/internal/envfile 1.059s ok github.com/novox/mesh-controller/internal/facts 1.070s ok github.com/novox/mesh-controller/internal/identity 4.918s ok github.com/novox/mesh-controller/internal/inventory 95.124s ok github.com/novox/mesh-controller/internal/lease 17.730s ok github.com/novox/mesh-controller/internal/licences 4.457s ok github.com/novox/mesh-controller/internal/licences/adapters 1.045s ok github.com/novox/mesh-controller/internal/link 55.104s ok github.com/novox/mesh-controller/internal/lint 2.365s ok github.com/novox/mesh-controller/internal/outward 1.083s ok github.com/novox/mesh-controller/internal/overlay 1.078s ok github.com/novox/mesh-controller/internal/secrets 1.538s ok github.com/novox/mesh-controller/internal/store 3.541s ok github.com/novox/mesh-controller/internal/testbus 1.227s ok github.com/novox/mesh-controller/internal/token 1.016s ```
Author
Contributor

Merge check at d5cf3b42

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • read by no module's build: cmd/mesh-controller/waiting_provider_test.go, internal/catalogue/secret_restart_test.go

Run by the build seat on g14 as build-1791680752090892571 (builds --log build-1791680752090892571).

--- the gate: build-agent, mesh-controller
mesh-controller: ok, 56 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-11T01:00:25Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-11T01:00:25Z

modules the change moves:
  - mesh-controller (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller

notes:
  - cmd/mesh-controller/waiting_provider_test.go and internal/catalogue/secret_restart_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.029s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	223.429s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.016s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.032s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.020s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.174s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.052s
ok  	github.com/novox/mesh-controller/internal/broker	2.604s
ok  	github.com/novox/mesh-controller/internal/builder	2.455s
ok  	github.com/novox/mesh-controller/internal/catalogue	6.534s
ok  	github.com/novox/mesh-controller/internal/conditions	2.384s
ok  	github.com/novox/mesh-controller/internal/envfile	1.032s
ok  	github.com/novox/mesh-controller/internal/facts	1.035s
ok  	github.com/novox/mesh-controller/internal/identity	4.057s
ok  	github.com/novox/mesh-controller/internal/inventory	75.021s
ok  	github.com/novox/mesh-controller/internal/lease	17.708s
ok  	github.com/novox/mesh-controller/internal/licences	3.719s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.009s
ok  	github.com/novox/mesh-controller/internal/link	51.346s
ok  	github.com/novox/mesh-controller/internal/lint	2.042s
ok  	github.com/novox/mesh-controller/internal/outward	1.041s
ok  	github.com/novox/mesh-controller/internal/overlay	1.027s
ok  	github.com/novox/mesh-controller/internal/secrets	1.423s
ok  	github.com/novox/mesh-controller/internal/store	3.206s
ok  	github.com/novox/mesh-controller/internal/testbus	1.168s
ok  	github.com/novox/mesh-controller/internal/token	1.017s
**Merge check** at `d5cf3b42` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - read by no module's build: cmd/mesh-controller/waiting_provider_test.go, internal/catalogue/secret_restart_test.go Run by the build seat on g14 as `build-1791680752090892571` (`builds --log build-1791680752090892571`). ``` --- the gate: build-agent, mesh-controller mesh-controller: ok, 56 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-11T01:00:25Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-11T01:00:25Z modules the change moves: - mesh-controller (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller notes: - cmd/mesh-controller/waiting_provider_test.go and internal/catalogue/secret_restart_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.029s ok github.com/novox/mesh-controller/cmd/mesh-controller 223.429s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.016s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.032s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.020s ok github.com/novox/mesh-controller/examples/route-proxy 1.174s ok github.com/novox/mesh-controller/internal/artifacts 1.052s ok github.com/novox/mesh-controller/internal/broker 2.604s ok github.com/novox/mesh-controller/internal/builder 2.455s ok github.com/novox/mesh-controller/internal/catalogue 6.534s ok github.com/novox/mesh-controller/internal/conditions 2.384s ok github.com/novox/mesh-controller/internal/envfile 1.032s ok github.com/novox/mesh-controller/internal/facts 1.035s ok github.com/novox/mesh-controller/internal/identity 4.057s ok github.com/novox/mesh-controller/internal/inventory 75.021s ok github.com/novox/mesh-controller/internal/lease 17.708s ok github.com/novox/mesh-controller/internal/licences 3.719s ok github.com/novox/mesh-controller/internal/licences/adapters 1.009s ok github.com/novox/mesh-controller/internal/link 51.346s ok github.com/novox/mesh-controller/internal/lint 2.042s ok github.com/novox/mesh-controller/internal/outward 1.041s ok github.com/novox/mesh-controller/internal/overlay 1.027s ok github.com/novox/mesh-controller/internal/secrets 1.423s ok github.com/novox/mesh-controller/internal/store 3.206s ok github.com/novox/mesh-controller/internal/testbus 1.168s ok github.com/novox/mesh-controller/internal/token 1.017s ```
mesh-admin merged commit 7493bd8f18 into main 2026-10-11 01:23:35 +00:00
mesh-admin deleted branch fix/405-a-waiting-provider-holds-its-consumers 2026-10-11 01:23:35 +00:00
This repo is archived. You cannot comment on pull requests.
No Reviewers
2 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-controller#216