Format two assigner files as gofmt writes them, so mesh-delivery's check passes again (issue 1126) #101

2026-10-28T19:03:46Z

mesh-tools commented

2026-10-28 19:03:46 +00:00

The cause: #99 (delivery 2 of L2) merged two assigner files not as gofmt writes them (cmd/mesh-delivery-assigner/pass.go and internal/assign/placement.go: one import order, one alignment), so the unit level of every later check of mesh-delivery fails (#100's at 19:01:52Z: "not as gofmt writes them, run gofmt -w"). This is gofmt -w on those two files alone, two lines; the unit suite and vet pass.

The independent review is bent (rules-are-weighed): the diff is gofmt-only, and the lead read it; the check covers the rest.

Issue 1126, ADR 0567.

Reviewed-by: lead-47@shanks at 5fe8ab11f1

The cause: #99 (delivery 2 of L2) merged two assigner files not as gofmt writes them (cmd/mesh-delivery-assigner/pass.go and internal/assign/placement.go: one import order, one alignment), so the unit level of every later check of mesh-delivery fails (#100's at 19:01:52Z: "not as gofmt writes them, run gofmt -w"). This is gofmt -w on those two files alone, two lines; the unit suite and vet pass. The independent review is bent (rules-are-weighed): the diff is gofmt-only, and the lead read it; the check covers the rest. Issue 1126, ADR 0567. Reviewed-by: lead-47@shanks at 5fe8ab11f1b4c7315fd7428c4fe17b5b3b9637ee

mesh-tools added 1 commit 2026-10-28 19:03:46 +00:00

Assigner: format pass.go and placement.go as gofmt writes them, which the check requires (issue 1126)

mesh/delivery merged: source.main moved to novox/mesh-delivery@a3a0d8f2ceb3

Details

mesh/check checking 5fe8ab11f1b4 on a3a0d8f2ceb3

5fe8ab11f1

mesh-tools commented

2026-10-28 19:03:49 +00:00

Delivery novox/mesh-delivery@5fe8ab11f1b4 — merged since 2026-10-28T19:08:06Z

Source — source.main moved to novox/mesh-delivery@a3a0d8f2ce. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Transitions

2026-10-28 19:03 (new) → proposed (announced): novox/mesh-delivery#101's head announced
2026-10-28 19:03 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
2026-10-28 19:08 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

**Delivery** `novox/mesh-delivery@5fe8ab11f1b4` — **merged** since 2026-10-28T19:08:06Z **Source** — source.main moved to novox/mesh-delivery@a3a0d8f2ceb3. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Transitions** - 2026-10-28 19:03 (new) → proposed (announced): novox/mesh-delivery#101's head announced - 2026-10-28 19:03 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-28 19:08 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.

mesh-tools merged commit a3a0d8f2ce into main

2026-10-28 19:08:03 +00:00

mesh-tools deleted branch fix/1126-assigner-gofmt

2026-10-28 19:08:04 +00:00

jschoubben referenced this issue from a commit

2026-10-28 19:38:36 +00:00

Checker integration tests: give the bed's node a record in the have, so the names check finds a name to ask with (ADR 0567 §12, issue 1126)

mesh-tools referenced this pull request

2026-10-28 21:07:15 +00:00

The assigner serves the seat mesh-placement's verbs on the seat's own name (issue 1126) #106

Sign in to join this conversation.